Closed Bug 719271 Opened 13 years ago Closed 13 years ago

Site-specific zoom level shouldn't apply to video and plugin documents

Categories

(Firefox :: General, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: polish)

Attachments

(1 file)

Bug 416661 excluded images from site-specific zooming, because "it is quite annoying to see normal pages zoomed when using pagezoom to zoom images" (bug 416661 comment 0). Bug 575830 comment 33 pointed out that this the same logic applies to other media document types, like video documents. We should update the code in browser-fullZoom.js to check mozSyntheticDocument instead of just "instanceof ImageDocument".
Try run for 8b7a0a182a1d is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=8b7a0a182a1d Results (out of 8 total builds): exception: 8 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mbrubeck@mozilla.com-8b7a0a182a1d
Attached patch patch (deleted) — Splinter Review
Attachment #590090 - Flags: review?
Attachment #590090 - Flags: review? → review?(gavin.sharp)
Try run for 0b586a5b7229 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=0b586a5b7229 Results (out of 155 total builds): success: 136 warnings: 18 failure: 1 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mbrubeck@mozilla.com-0b586a5b7229
Comment on attachment 590090 [details] [diff] [review] patch Did the test fail before the patch? Jared suggested it doesn't in bug 575830 comment 35. Maybe some other form of synthetic document would make a better test?
Attachment #590090 - Flags: review?(gavin.sharp) → review+
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #4) > Did the test fail before the patch? Jared suggested it doesn't in bug 575830 > comment 35. Maybe some other form of synthetic document would make a better > test? Yes, the test fails without the patch. Before the patch, video documents used site-specific zoom. So they weren't affected by bug 575830 (zoom resets to 1 on tab switching), but zooming a video would cause other pages in the site to zoom and vice-versa (which is the problem that bug 416661 fixed for images).
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 12
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 806046
Depends on: 842001
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: