Justin Dolske [:Dolske] Assignee
	Description • 13 years ago

Bug 376997 changed default background-color for ImageDocuments to a dark gray (and other bugs had previously moved related styles into standalone CSS files.) Some images don't look great on a ark background (just as some didn't look great on a white background). I'm open to simple solutions to let the user choose, and here's one such approach. (I had initially been thinking about doing this as a context-menu, but that's a little more work I think.)

Attached patch works, but needs a little more work:

* "White background" isn't localized.
* Could call it generically "Alternate" lest themes want to change it, but I don't think we want to support that.
* Enabling the Page Style menu enables it for videos too, which probably isn't wanted.

But it's pretty simple!

	Gian-Carlo Pascutto [:gcp]
	Comment 1 • 13 years ago

View->Page Style isn't accessible by default right? It requires people to know they can get old-style menus by pressing ALT, then finding this feature somehow.

If it's a real problem that some images don't look good on a dark background, maybe either fix bug 376997 (Bug 717226), or consider sticking it where it would normally be expected: in the color menu. Of course, in that case you'll have to solve the problem in that we're already defining a background color (white) and bug 376997 completely ignores it (by making it dark grey anyway).

Really, if there's a need to be able to switch to a white background (and I think we agree there is), then sticking it in a place where 99% of our users will never find it makes very little sense.

	Arash
	Comment 2 • 13 years ago

This may be a good feature for those who wants to view photo attachments, etc. but for web developers who generate dynamic images, etc. this is really bad, especially when you have transparency in your image.

Also since the image is centered you cannot see the borders of a transparent image. Please revert to old style. 

If you want to enhance anything, you can respect the orientation information in images (which may be in EXIF) so photos attached by mobile deivces like iPhone to emails won't be displayed rotated when opened in browser. I'm sure HUGE amount of users are having this problem!

	Jared Wein [:jaws] (please needinfo? me)
	Comment 3 • 13 years ago

(In reply to Arash from comment #2)
> If you want to enhance anything, you can respect the orientation information
> in images (which may be in EXIF) so photos attached by mobile deivces like
> iPhone to emails won't be displayed rotated when opened in browser. I'm sure
> HUGE amount of users are having this problem!

Hmmm, I hadn't thought of that before. I like it :)

I did a search on Bugzilla and found bug 298619 for it.