Closed
Bug 720325
Opened 13 years ago
Closed 12 years ago
GeckoSmsManager is missing serialVersionUIDs
Categories
(Core :: General, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: gcp, Assigned: vicamo)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
There's a whole bunch of those: /home/morbo/hg/mozilla-central/mobile/android/base/GeckoSmsManager.java:583: warning: [serial] serializable class IdTooHighException has no definition of serialVersionUID class IdTooHighException extends Exception { } They're warnings, not errors. But given that this is currently *the only thing* in the entire project that's spamming warnings, fixing it would be appreciated.
Updated•13 years ago
|
Assignee: nobody → lucasr.at.mozilla
tracking-fennec: --- → 11+
Priority: -- → P2
Comment 1•13 years ago
|
||
I'm not seeing those warnings anymore. Closing.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Comment 2•13 years ago
|
||
That's because the feature was disabled be default. You'd see them again if you enable it.
Assignee: lucasr.at.mozilla → nobody
Blocks: websms
Status: RESOLVED → REOPENED
Product: Fennec Native → Core
QA Contact: general → general
Resolution: WORKSFORME → ---
Updated•13 years ago
|
Keywords: fennecnative-releaseblocker
Updated•13 years ago
|
Status: REOPENED → NEW
Keywords: fennecnative-releaseblocker
Updated•12 years ago
|
tracking-fennec: 11+ → ?
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → vyang
Assignee | ||
Comment 4•12 years ago
|
||
Blocking bug 742790 for it has to be verified with WebSMS Android backend.
Blocks: 742790
Comment 5•12 years ago
|
||
Comment on attachment 674174 [details] [diff] [review] add serialVersionUID for serializable WebSMS exception classes Review of attachment 674174 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/GeckoSmsManager.java @@ +883,5 @@ > MessagesListManager.getInstance().clear(); > } > + > + class IdTooHighException extends Exception { > + private static final long serialVersionUID = 1L; what is serialVersionUID for?
Comment 6•12 years ago
|
||
(In reply to Brad Lassey [:blassey] from comment #5) > Comment on attachment 674174 [details] [diff] [review] > add serialVersionUID for serializable WebSMS exception classes > > Review of attachment 674174 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mobile/android/base/GeckoSmsManager.java > @@ +883,5 @@ > > MessagesListManager.getInstance().clear(); > > } > > + > > + class IdTooHighException extends Exception { > > + private static final long serialVersionUID = 1L; > > what is serialVersionUID for? nevermind, read up on it. If we're going to define these, let's at least make them unique.
Updated•12 years ago
|
Attachment #674174 -
Flags: review?(blassey.bugs) → review-
Assignee | ||
Comment 7•12 years ago
|
||
Randomize serialVersionUID. Addressed review comment #6.
Attachment #674174 -
Attachment is obsolete: true
Attachment #674562 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #674562 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/164d7dd54ee0
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/164d7dd54ee0
Status: NEW → RESOLVED
Closed: 13 years ago → 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•11 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•