I want to extend the fix for bug 14368, so that F10 can access the main menu on all platforms. MarkH mentioned that all we need to do is take out the ifdef's from the patch. It's really that the bug was reported wrong originally, it should have said for all platforms. I trying to avoid bugzilla bloat, but I can file a different bug if you like. As far as Mac, we use their menu systems - most of the time. At some point, we might have an accessible self-voicing Mozilla distro for Mac that uses our menu systems, and thus has keyboard access. I wouldn't want to have to come back later and fix the F10 key a 3rd time. If we just take out the ifdef's, we'll be fine.

-> I'll take this one.

-> 0.9.6

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)

This patch can make F10 access main menu on UNIX and LINUX, I have test it on Linux(Intel) and Solarix(Sparc), it works fine. What this patch did is very simple, open the XP_UNIX compling switch to extend the function of bug 14368 to UNIX platform. Aaronl, John ,can you review this patch? thanks. --Jay

I just talked with one of the Mac guys on IRC about the effects of this on Mac. He says that Mac doesn't support this behavior and we should not open the door for it. So i would propose we change the ifdef to the following just to make it clear that all other platforms are ok with this, but that Mac specifically does not want it: #if !defined(XP_MAC) && !defined(XP_MACOSX) We need both defines in there because OSX *is* XP_UNIX, and isn't XP_MAC apparently. This will allow everyone but Mac to use F10 as the menu accessor. :-) Minor change, please repost the patch and I'll review it, get it sr'd and throw it in.

I am a little confused by XP_MACOSX, because I never see it on mozilla source before, John, what does it for? where can see the definition on the source code? Thanks. Anyway, I repost the new patch, and on both Windows and Unix F10 works fine, and sure Mac will not regonize F10 as main menu accessor because I disabled XP_MAC. --Jay

comment nit: BeOS and OS/2 are not Unix nor Windows respectively, for your actual committed comment i'd request that you not mention Unix/Windows explicitly.

I have no right to make former 2 patches obselete now... I forgot to modify my comments in my last patch, so I sumbit a new patch now --jay

Hi, John: I reposted the patch, can you r=? Thanks Jay

Comment on attachment 72963 [details] [diff] [review] new patch with comment revision looks good. r=jgaunt please go to sfraser@netscape.com for sr since this has some Mac specific implications.

Comment on attachment 72963 [details] [diff] [review] new patch with comment revision sr=sfraser

Comment on attachment 72963 [details] [diff] [review] new patch with comment revision a=asa (on behalf of drivers) for checkin to the 1.0 trunk

checked in. Many thanks to Jay for this patch

Thanks John for help me to checkin --Jay

vrfy'd fixed on linux rh7.2 and win2k using 2002.04.09 comm bits. F10 focuses the menubar (goes to File, to be exact). no effect on Mac 10.1.3 --can use control+M, if full keyboard access is turned on (and using the default control+letter keys).

Reverting summary. Win32 was bug 14368.