Closed
Bug 720831
Opened 13 years ago
Closed 13 years ago
Use a whitelist for mozTelephony instead of a single url
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mounir
:
review+
philikon
:
feedback+
|
Details | Diff | Splinter Review |
This will let Gaia's homescreen use navigator.mozTelephony.addEventListener to react to incoming calls.
Attachment #591260 -
Flags: review?(bent.mozilla)
Comment 1•13 years ago
|
||
Comment on attachment 591260 [details] [diff] [review]
Use a whitelist
Review of attachment 591260 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #591260 -
Flags: review?(bent.mozilla) → review+
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Note for posterity: this is a placeholder for two things, real permissions support, and an intents impl in gecko/b2g.
Updated•13 years ago
|
Blocks: webtelephony
Comment 3•13 years ago
|
||
Comment on attachment 591260 [details] [diff] [review]
Use a whitelist
This patch is not enough by itself. Currently the navigator.mozTelephony implementation does not deal with being exposed to multiple pages currently. Bug 720892 is an example of erroneous behaviour (we might morph that bug into fixing this since bent also expressed the desire to loosen the restrictions on mozTelephony access.)
Until that happens, though, I don't think we should land this patch.
Attachment #591260 -
Flags: feedback-
Comment 4•13 years ago
|
||
Philipp, open a bug and make it block this one but f- means the patch is wrong which is not the case here. If there is a bug blocking this one, it's clearer that this one has to be hold until the blocker is fixed.
Assignee | ||
Comment 5•13 years ago
|
||
> Until that happens, though, I don't think we should land this patch.
Agreed. That's the reason I've not landed it yesterday.
Comment 6•13 years ago
|
||
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #4)
> Philipp, open a bug and make it block this one but f- means the patch is
> wrong which is not the case here. If there is a bug blocking this one, it's
> clearer that this one has to be hold until the blocker is fixed.
Fair enough. I morphed bug 720892.
Comment 7•13 years ago
|
||
Comment on attachment 591260 [details] [diff] [review]
Use a whitelist
FWIW, I don't disagree with the patch itself. So you're right about the bugzilla mechanics, Mounir.
Attachment #591260 -
Flags: feedback- → feedback+
Comment 8•13 years ago
|
||
This was assimilated into the patch in bug 717451.
You need to log in
before you can comment on or make changes to this bug.
Description
•