Closed Bug 721080 Opened 13 years ago Closed 13 years ago

Touch events should release their lock on panning if the page doesn't call preventDefault

Categories

(Firefox for Android Graveyard :: General, defect, P2)

x86
Linux
defect

Tracking

(fennec11+)

RESOLVED FIXED
Firefox 13
Tracking Status
fennec 11+ ---

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(2 files, 1 obsolete file)

As a first draft of the touch events prevent panning stuff, all pages with touch events will prevent panning until a timeout expires and they haven't been told not to. We should instead, if the first touch move (or any touchmove for that matter) comes back with no preventDefault, send a message to java telling it to enable panning and other actions.
Blocks: 603008
tracking-fennec: --- → 11+
Assignee: nobody → wjohnston
Priority: -- → P2
Attached patch WIP Patch (obsolete) (deleted) — Splinter Review
This is just a WIP for someone else in case I don't get back to this. This seems to work, except i ocassionally see jumps in the page. I think I am occasionally enabling panning (which then runs through the entire queued event queue) for a brief second when I shouldn't....
Attached patch Patch (deleted) — Splinter Review
This works good for me.
Attachment #592941 - Attachment is obsolete: true
Attachment #593313 - Flags: review?(doug.turner)
Comment on attachment 593313 [details] [diff] [review] Patch Review of attachment 593313 [details] [diff] [review]: ----------------------------------------------------------------- looks fine.
Attachment #593313 - Flags: review?(doug.turner) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 593313 [details] [diff] [review] Patch User impact if declined: Makes touch events work better (i.e. very little delay in panning on pages with touch event listeners, but that don't want to prevent panning. I would be leery to turn them on without this. Testing completed (on m-c, etc.): Landed on mc 2/1/12 Risk to taking this patch (and alternatives if risky): Low risk. Mobile only fixes to broken code. String changes made by this patch: None.
Attachment #593313 - Flags: approval-mozilla-aurora?
Comment on attachment 593313 [details] [diff] [review] Patch If/When we move this to Aurora, we would likely also want it on beta.
Attachment #593313 - Flags: approval-mozilla-beta?
Attached patch Follow up breakage fix (deleted) — Splinter Review
Attachment #593553 - Flags: review?(doug.turner)
Attachment #593553 - Flags: review?(doug.turner) → review+
Comment on attachment 593313 [details] [diff] [review] Patch [Triage Comment] Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593313 - Flags: approval-mozilla-beta?
Attachment #593313 - Flags: approval-mozilla-beta+
Attachment #593313 - Flags: approval-mozilla-aurora?
Attachment #593313 - Flags: approval-mozilla-aurora+
Comment on attachment 593553 [details] [diff] [review] Follow up breakage fix [Triage Comment] Mobile only - pre-approving since this likely needs to land along with the original patch.
Attachment #593553 - Flags: approval-mozilla-beta+
Attachment #593553 - Flags: approval-mozilla-aurora+
Comment on attachment 593313 [details] [diff] [review] Patch Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions. If this changes in the future, we will likely do a mass uplift of all native fennec changes. For now, let's get these bugs off the channel triage radar. [Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]
Attachment #593313 - Flags: approval-mozilla-beta+
Attachment #593313 - Flags: approval-mozilla-aurora+
Attachment #593553 - Flags: approval-mozilla-beta+
Attachment #593553 - Flags: approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: