Closed Bug 72112 Opened 24 years ago Closed 24 years ago

nsIPrompt impls need to coallesce into a single impl

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9

People

(Reporter: jud, Assigned: danm.moz)

References

Details

(Keywords: embed)

Attachments

(1 file)

In order for nsIPrompt dialog implementatin overriding to work, we need all the nsIPrompt usages to funnel up to a single implementation. we talked about having a single nsIPrompt service that was front-ended by a nsIPromptInternal implementation that resides above necko which shields necko nsIPrompt calls from having to know about nsIDOMWindow. Other current nsIPrompt impls/usages would just use the root nsIPrompt dialog service directly (unless they too needed some nsIDOMWindow shielding wrapper).
Blocks: 64833, 70229
Target Milestone: --- → mozilla0.9
Keywords: embed
Blocks: 65233
Nice... no patches... So anyway: http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/content/AccountWizard.js#175 Uppercase C on Confirm instead of lowercase. Patch coming up.
Attached patch [patch] Fix case. (deleted) — Splinter Review
Been waiting for someone to knock me around for that. Thanks Jag! (I broke that file and 20 others. Fixes for all have been checked in.)
No longer blocks: 64833
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein
nsIPrompt is now universally implemented by nsIPromptService. (Or rather, Viewer and some of the testbeds still claim to implement nsIPrompt, but they'll never be asked for their implementation, since that code path has been unhooked; diverted to the new service.) Viewer is not slated for updating, since it has never cared about such things and it would be astoundingly tedious to make it care. Work remaining on the testbed apps is accounted for in bug 75745.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
changed QA contact to dsirnapalli. He's looking at this interface.
QA Contact: depstein → dsirnapalli
-- verified.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: