we have a lot of code that references application.ini. For mobile we don't even have one anymore! If we can get this same information from the getInfo.html run we do as a first run of talos that would be better. We also need to see what specific information from application.ini we care about.

Looking at this further we need 3 pieces of data: branchName - passed in via command line to PerfConfigurator.py BuildID - we can get this from getInfo.html via window.navigator.buildID sourceStamp - no way to get this from browser (that I can find) we just need to figure out sourceStamp, and I believe we can do that with a commandline parameter to PerfConfigurator.py. When looking at the logs for talos, we have the revision in most steps. We should be able to add a --revision argument and make that work.

We have a step on the buildbot job called "get build info" which grabs properties from doing "cat ../FirefoxNightly.app/Contents/MacOS/application.ini". The properties captured are: buildid: '20120130023331' revision: 'bfeeb813aef2' repo_path: 'http://hg.mozilla.org/mozilla-central' If I am not mistaken we also receive the "Revision" (rather than a property) from the sendchange we receive: buildbot sendchange ... --revision 875a31fd0056 ... There is also a revision in about:buildconfig. Are you referring initially talking about the talos code? [1] or the "get build info" step that we have? (I believe we get those values to do tinderbox prints). [1] http://mxr.mozilla.org/build/search?find=%2Ftalos%2F&string=Application.ini

This bug is intended for talos proper, but it could extend further. I think if it is possible to get a --revision added to the talos commandline from buildbot, then we can resolve this bug for talos. about:buildconfig has the information we want, but this is a static .html file generated during compile time.

steps to success: * add a --revision argument to Perfconfigurator/talos. * modify buildbot to use the --revision argument.

It is worth noting that this data is only of importance in production (and especially sending to graphserver). So it should be optional for non-reporting cases (though, of course, mandatory for reporting cases, which is currently == production). And this way i don't have to cp ~/firefox/application.ini remoteapp.ini for every new directory I want to test on mobile (a big barrier to newcomers + mobile testing)

I have said this at least 10 times if not 20, we do not need this with --develop, so lets fix that.

This patch removes most of the work from the running process, just not the perfconfigurator step. If we find this useful, we can finish up this cleanup process. I suspect we will have to leave in the application.ini bits until we can get the releng scripts to use --sourceStamp.

Comment on attachment 611560 [details] [diff] [review] remove our dependency on application.ini (1.0) I'm not excited about the regex parsing, but it will do for now. I'd also recommend removing the commented code entirely. But these are both nits