Closed
Bug 722057
Opened 13 years ago
Closed 13 years ago
Add memory reporter for DOM CC marking buffers
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
INVALID
People
(Reporter: mccr8, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MemShrink])
Bug 721515 will add two new global arrays that persist in between CCs to remember where bits have been set. These should be added to the memory reporter, probably to the DOM memory reporter. I'm not sure how large they will be in practice, but maybe a few thousand each.
Comment 1•13 years ago
|
||
Bug 721515 doesn't add any persistent arrays. The arrays are alive either from the first CanSkip to the
end of forgetSkippable, or from CanSkipInCC to Unlink.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 2•13 years ago
|
||
So they only maintain state across a single forgetSkippable? (Or a single CC in the latter case.) It can still be good to add them in, just in case somebody breaks something later. Maybe not a high priority then.
Comment 3•13 years ago
|
||
Yes, they are just for single forgetSkippable or cycleCollect.
Reporter | ||
Comment 4•13 years ago
|
||
Well, it would still be good to have it, eventually. I have a similar reporter for the cycle collector graph, even though it is cleared in between cycle collections, because it is held in a persistent global structure. But yeah this is probably not a big deal.
What do you think, Nick? This is a globally held data structure that in practice should only going to be alive for a few milliseconds. Should I bother?
Comment 5•13 years ago
|
||
Well, the "cycle-collector" number can get really big (multiple MBs) if you repeatedly hit "Update" in about:memory. Could the same thing happen with this buffer?
Comment 6•13 years ago
|
||
Usually these buffers are 1 kB, but can get
Comment 7•13 years ago
|
||
up to few kilobytes. Well, in pathological cases even more.
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•