Closed
Bug 722318
Opened 13 years ago
Closed 13 years ago
Fix race in connect_to_supplicant
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
Right now, nsWifiWorker.js assumes that connect_to_supplicant always returns before the supplicant has made its connection to the network. If this isn't the case, then it doesn't do any sort of DHCP/DNS stuff, leaving the network in an inconsistent state (up but with no IP).
There's an easy fix for this that I'll attach. I had to hack my version of nsWifiWorker.js to even test this fix (since for me connect_to_supplicant always does return before we connect) so if this doesn't work for you, let me know.
|
Assignee | |
Comment 1•13 years ago
|
||
This should be pretty straightforward. I also took this opportunity to get rid of the debugging "automatically connect to Mozilla Guest" code. If you think we should leave it in for now, let me know.
Attachment #592709 -
Flags: review?(gal)
|
||
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
|
||
Comment 2•13 years ago
|
||
Comment on attachment 592709 [details] [diff] [review]
Proposed fix
Works for me.
Attachment #592709 -
Flags: feedback+
|
||
Updated•13 years ago
|
Attachment #592709 -
Flags: review?(gal) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 592709 [details] [diff] [review]
Proposed fix
https://hg.mozilla.org/integration/mozilla-inbound/rev/c52ce509a5c3
Attachment #592709 -
Flags: checkin+
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•