Closed Bug 722368 Opened 13 years ago Closed 13 years ago

Report slow SQL created from dynamic strings to Telemetry

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: vladan, Assigned: vladan)

References

Details

(Keywords: perf, Whiteboard: [Snappy:P2])

Attachments

(4 files, 4 obsolete files)

As a privacy safeguard, we are currently only reporting on the slow execution of prepared SQL statements. Consequently we are missing a lot of time-consuming SQL created from dynamic strings. We should investigate collecting metrics on such SQL and perhaps reporting only its JavaScript call stack instead of the actual SQL string.
Whiteboard: [Snappy:P2]
Assignee: nobody → vdjeric
Attachment #602230 - Flags: review?(taras.mozilla)
Attached patch about-telemetry change (obsolete) (deleted) — Splinter Review
Attachment #602352 - Attachment is patch: true
Attached file New about-telemetry, v0.9.2 (obsolete) (deleted) —
Comment on attachment 602352 [details] [diff] [review] about-telemetry change s/fullSlowSQL/debugSlowSQL/. I'm still pondering rest of the stuff
Comment on attachment 602234 [details] Sample about:telemetry output and corresponding Telemetry Ping report I'm not sure of utility of telling addon dbs apart from non-addon dbs within the ping. For now we should report a cumulative number like "dynamic query on x.sqlite" We should also add a toolkit.telemetry.debugSlowSQL=false pref and gate private sql recording on that.
Comment on attachment 602230 [details] [diff] [review] Report full SQL strings locally & aggregate private stats for Telemetry, v1 r- based on irc discussion
Attachment #602230 - Flags: review?(taras.mozilla) → review-
Attached patch about-telemetry change, v2 (deleted) — Splinter Review
Attachment #602352 - Attachment is obsolete: true
Attached file New about-telemetry, v0.9.2 (deleted) —
Attachment #602353 - Attachment is obsolete: true
Attachment #602230 - Attachment is obsolete: true
Attachment #603909 - Flags: review?(taras.mozilla)
Attached file Sample about:telemetry output, v2 (deleted) —
Attachment #602234 - Attachment is obsolete: true
Comment on attachment 603909 [details] [diff] [review] Report full SQL strings locally & aggregate private stats for Telemetry, v2 AddonDb -> TrackedDB + fullSql.AppendPrintf(" /* addon DB %s */", dbName.BeginReading()); -- is the proper comment prefix for SQL. s/addon/untracked/
Attachment #603909 - Flags: review?(taras.mozilla) → review+
Depends on: 712109
Target Milestone: --- → mozilla14
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: