Closed
Bug 722514
Opened 13 years ago
Closed 13 years ago
AndroidBrowserRepositorySession.java reconcileRecords incorrect guid string comparison
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dchanm+bugzilla, Unassigned)
References
Details
An object reference comparison is used to compare the guid properties of the record type. [1] guid is defined as a String in [2] so equals() or compareTo() should be used instead.
[1] - https://github.com/mozilla-services/android-sync/blob/master/src/main/java/org/mozilla/gecko/sync/repositories/android/AndroidBrowserRepositorySession.java#L525
[2] - https://github.com/mozilla-services/android-sync/blob/master/src/main/java/org/mozilla/gecko/sync/repositories/domain/Record.java#L48
|
||
Comment 1•13 years ago
|
||
No longer the case after Bug 709348 lands. It rewrites all this code.
Depends on: 709348
|
|
||
Updated•13 years ago
|
Priority: -- → P2
|
||
Comment 2•13 years ago
|
||
As of https://github.com/mozilla-services/android-sync/commit/26dbaf947aac59bb2a4c3571c947269e0dd78cc7
Every use of == in `find android-sync/src/main/java/org/mozilla/gecko/sync/repositories` looks good to me. Can we close this?
|
|
||
Comment 3•13 years ago
|
||
I'll take your word for it, Nick, after Comment 1.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•12 years ago
|
Product: Mozilla Services → Android Background Services
|
||
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•