This patch: - Measures a few more small JS things. I probably shouldn't have bothered, judging from Gmail they'll be lucky to reach 0.01% of total explicit, but it's done now. - Tree-ifies the "object-slots" and "object-elements" reporters. - Better separates JSObject::computedSizeOfThisSlotsElements() and JSObject::sizeOfExcludingThis() -- the latter now always takes a non-NULL |mallocSizeOf| argument. - Converts some reinterpret_casts to static_casts in vm/ArgumentsObject.h.

=> - Measures a few more small JS things. I probably shouldn't have bothered, > judging from Gmail they'll be lucky to reach 0.01% of total explicit, but > it's done now. Oops, I meant 0.1%!

Comment on attachment 592950 [details] [diff] [review] patch Review of attachment 592950 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsobjinlines.h @@ +1233,5 @@ > + *miscSize += toFunction()->sizeOfMisc(mallocSizeOf); > + } else if (isArguments()) { > + *miscSize += asArguments().sizeOfMisc(mallocSizeOf); > + } else if (isRegExpStatics()) { > + *miscSize += mallocSizeOf(getPrivate()); Can you put this in a SizeOfRegExpStaticsData or something which is near the existing private accessors on RegExpStatics objects? ::: js/src/vm/GlobalObject.cpp @@ +512,5 @@ > return true; > } > > +size_t > +GlobalObject::sizeOfMisc(JSMallocSizeOfFun mallocSizeOf) const This doesn't seem to get called under sizeOfExcludingThis?

> > +size_t > > +GlobalObject::sizeOfMisc(JSMallocSizeOfFun mallocSizeOf) const > > This doesn't seem to get called under sizeOfExcludingThis? Good catch! The RegExpStatics hangs off the GlobalObject so I thought I needed this but then I realized that normal heap enumeration will hit the RegExpStatics object anyway. But I forgot to remove it. Thanks.