Closed
Bug 722965
Opened 13 years ago
Closed 13 years ago
Remove MOZ_TOUCH ifdefs
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
We put these in so we could move touch events forward on mobile with minimum changes to desktop. We should remove them now (assuming the tests pass...)
Assignee | ||
Comment 1•13 years ago
|
||
Lets see how this fares on try:
https://tbpl.mozilla.org/?tree=Try&rev=0aeeb6abc514
Assignee: nobody → wjohnston
Comment 2•13 years ago
|
||
Try run for 0aeeb6abc514 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=0aeeb6abc514
Results (out of 219 total builds):
success: 178
warnings: 39
failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/wjohnston@mozilla.com-0aeeb6abc514
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 602153 [details] [diff] [review]
Patch
Looks good in tests! I didn't pull the MOZ_TOUCH stuff from gonk.
Attachment #602153 -
Flags: review?(bugs)
Comment 4•13 years ago
|
||
I landed bug 664707 which touches both GetEventCoordinatesRelativeTo in the same way, so when you land you'll have to account for that.
Updated•13 years ago
|
Attachment #602153 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•