Closed Bug 723418 Opened 13 years ago Closed 13 years ago

in function GonkCameraInputStream::Init(nsACString_internal&, nsCaptureParams*):/home/cjones/mozilla/mozilla-central/netwerk/protocol/device/GonkCaptureProvider.cpp:263: error: undefined reference to 'HAL_getNumberOfCameras'

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: cjones, Assigned: fabrice)

References

Details

(Whiteboard: [inbound])

Attachments

(2 files)

Don't link against HAL_getNumberOfCameras because we don't have a camera library on the emulator
(deleted), patch
gal
: review+
Details | Diff | Splinter Review
followup
(deleted), patch
cjones
: review+
Details | Diff | Splinter Review
This happens when I build b2g while configured for the emulator. Apparently the emulator doesn't have a libcamera.so to link against, at least our version of it.
Attachment #593741 - Flags: review?(gal) → review+
Attached patch followup (deleted) — — Splinter Review
The previous patch will fail with devices that have only one camera and try to open the second one. This patch dlsym() the HAL_getNumberOfCameras() instead.
Assignee: jones.chris.g → fabrice
Attachment #593864 - Flags: review?(jones.chris.g)
Comment on attachment 593864 [details] [diff] [review] followup This doesn't make sense as a member method here, imho. I hacked because I didn't want to redactor so as to share the lib handle. I don't trust the linker. But let's comprise. Make this a static method and r=me.
Attachment #593864 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/mozilla-central/rev/b71df850fb73
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: