Closed
Bug 723509
Opened 13 years ago
Closed 13 years ago
update Unicode support to v6.1
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jfkthame, Assigned: smontagu)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
We should update the various data tables, etc., that depend on Unicode, now that v6.1 is officially released.
This mainly affects code/data under intl/, presumably, but also some in gfx/thebes/.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → smontagu
Assignee | ||
Comment 2•13 years ago
|
||
In the past we have generally pushed Unicode updates to release branches so that releases support the latest Unicode version. In the rapid-release model, I think we can just let the update ride the trains. As it happens this release will show the longest delay possible if we follow that model: 6.1 support will be in Firefox 13, due for release on 2012-06-05. I think this is a reasonable delay.
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #594584 -
Flags: review?(jfkthame)
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 594584 [details] [diff] [review]
Patch
Review of attachment 594584 [details] [diff] [review]:
-----------------------------------------------------------------
rs=jfkthame. I didn't attempt to check all the updates to various generated tables :) but this looks fine.
::: intl/unicharutil/util/nsBidiUtils.h
@@ +278,5 @@
> #define IS_IN_BMP_RTL_BLOCK(c) ((0x590 <= (c)) && ((c) <= 0x8ff))
> #define IS_RTL_PRESENTATION_FORM(c) (((0xfb1d <= (c)) && ((c) <= 0xfdff)) || \
> ((0xfe70 <= (c)) && ((c) <= 0xfefc)))
> +#define IS_IN_SMP_RTL_BLOCK(c) (((0x10800 <= (c)) && ((c) <= 0x10fff)) || \
> + ((0x1E800 <= (c)) && ((c) <= 0x1EFFF)))
Please use lowercase hex here; consistency with the surrounding code makes it easier to read, IMO.
Attachment #594584 -
Flags: review?(jfkthame) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla13
Comment 6•13 years ago
|
||
Tom, does jseng need anything updated?
Comment 7•13 years ago
|
||
I just run js/src/vm/make_unicode.py and indeed it looks like some stuff that is relevant to JS changed. Because I am bit lazy did anything conceptually in Unicode (and or the Unicode format) change? I would guess not.
Reporter | ||
Comment 8•13 years ago
|
||
There'll be a few changes due to new case-mappings, etc., but it looks like re-running make_unicode.py with the latest data file should be all you need.
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•