Closed
Bug 723618
Opened 13 years ago
Closed 13 years ago
compile errors on Mac OS X 10.7 targeting 10.6 SDK
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jaas, Assigned: espindola)
References
Details
Attachments
(2 files)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Full log attached.
In file included from /Users/josh/src/mozilla/ff_trunk_debug_x86_64/dom/plugins/ipc/PluginUtilsOSX.mm:42:
In file included from /Users/josh/src/mozilla/ff_trunk_debug_x86_64/dom/plugins/ipc/PluginUtilsOSX.h:45:
In file included from ../../../dist/include/nsCoreAnimationSupport.h:49:
../../../dist/include/nsIOSurface.h:48:7: error: redefinition of 'NSOpenGLContext' as different kind of symbol
class NSOpenGLContext;
|
||
Comment 1•13 years ago
|
||
I'm seeing this as well. I also fingered bug 715785 as the root cause. Although, I haven't proved it.
This is the first time I haven't been able to build with the 10.7 SDK since 10.7 first came out (July 2011). Is backing out https://hg.mozilla.org/mozilla-central/rev/67b0e13d7a62 justified?
|
||
Comment 2•13 years ago
|
||
No, but we can fix this instead :)
|
Assignee | |
Comment 4•13 years ago
|
||
I added a patch to bug 723738.
Should I just move it here?
|
|
Assignee | |
Comment 5•13 years ago
|
||
With this forward declaration the code reduces to
@interface NSOpenGLContext {
}
@end
class NSOpenGLContext;
which gcc accepts but clang intentionally rejects.
https://tbpl.mozilla.org/?tree=Try&rev=b8b6eed5b818
|
||
Comment 6•13 years ago
|
||
Comment on attachment 593996 [details] [diff] [review]
remove forward declaration
I can review this. r+
Attachment #593996 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•