Closed
Bug 723637
Opened 13 years ago
Closed 13 years ago
layout/reftests/transform-3d/matrix3d-*.html don't seem to test anything
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
layout/reftests/transform-3d/matrix3d-1a.html and layout/reftests/transform-3d/matrix3d-2a.html both test that a div with a particular matrix3d() transform is equivalent to another div. But the div just contains a line of text, and the transform sends the text off the screen to the top in both cases, so it's not actually testing that they're the same. In particular, matrix3d-2a.html is testing that "matrix3d(1,0,0,0, 0,2,0,0, 0,0,3,0, 4,5,6,1)" is equivalent to "scale3d(1,2,3) translate3d(4px,5px,6px)", but it's not -- it's equivalent to "translate3d(4px,5px,6px) scale3d(1,2,3)".
These were added in part 13 of the patchset for bug 505115. Patch to be attached in a moment.
Assignee | ||
Comment 1•13 years ago
|
||
Reftests in this directory pass both before and after this patch. If I undo the reversal of translate3d() and scale3d() in matrix3d-2a.html, but still add background: gold, I get a TEST-UNEXPECTED-FAIL.
Assignee: nobody → ayg
Attachment #593916 -
Flags: review?
Assignee | ||
Updated•13 years ago
|
Attachment #593916 -
Flags: review? → review?(roc)
Assignee | ||
Updated•13 years ago
|
Attachment #593916 -
Flags: review?(roc) → review?(matt.woodrow)
Attachment #593916 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Whiteboard: [autoland-try]
Updated•13 years ago
|
Whiteboard: [autoland-try] → [autoland-in-queue]
Comment 2•13 years ago
|
||
Autoland Patchset:
Patches: 593916
Branch: mozilla-central => try
Destination: http://hg.mozilla.org/try/rev/cff0c83c75b0
Try run started, revision cff0c83c75b0. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=cff0c83c75b0
Comment 3•13 years ago
|
||
Try run for cff0c83c75b0 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=cff0c83c75b0
Results (out of 207 total builds):
exception: 2
success: 177
warnings: 27
failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-cff0c83c75b0
Updated•13 years ago
|
Whiteboard: [autoland-in-queue]
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•