Closed
Bug 723788
Opened 13 years ago
Closed 2 years ago
Poor performance on toggling annotation with opengrok
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: ginnchen+exoracle, Unassigned)
References
(Depends on 1 open bug, )
Details
Open the URL
Click the Annotate to toggle annotation.
With Safari 5.1.2, it takes 1-2 seconds.
With Firefox 10, it takes about 55 seconds.
Profiling shows
nsLineBox::IndexOf
and
nsLineBox::RFindLineContaining
Code of toggle annotation:
function toggle_annotations() {
$("span").each(function() {
if (this.className == 'blame') {
this.className = 'blame-hidden';
} else if (this.className == 'blame-hidden') {
this.className = 'blame';
}
}
);
}
Not sure if this bug is blocked by Bug 682052 or it is a dupe of that bug.
|
||
Comment 1•13 years ago
|
||
Yeah, so the page goes through and reframes a bunch of stuff, and we have to find the lines for each one...
Let's keep this dependent on bug 682052 for now, though I'm 90% sure it's a dup of one of the other bugs that one blocks.
|
||
Updated•2 years ago
|
Severity: normal → S3
|
||
Comment 2•2 years ago
|
||
The site seems to be gone, but here's the latest wayback machine capture:
https://web.archive.org/web/20100828133920/http://src.opensolaris.org:80/source/xref/onnv/onnv-gate/usr/src/uts/common/fs/nfs/nfs4_vnops.c
It loads quite fast (~2 seconds) in current Nightly on my machine, spending only ~200ms in reflow. Here's a profile:
https://share.firefox.dev/3obTMSH
So: there aren't any 55-second hangs that are reproducible here at this point. --> WORKSFORME
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•