Closed
Bug 723864
Opened 13 years ago
Closed 13 years ago
Remove dead default cases in gfx
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
gcc cannot figure out that a switch covers all the values, so we depend on 723114. I have pushed a combined patch to try in
https://tbpl.mozilla.org/?tree=Try&rev=a2a0f4979b8d
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=805b7cac0030
Added a missing include :-(
Sorry for the noise.
Attachment #594106 -
Attachment is obsolete: true
Attachment #594106 -
Flags: review?(jmuizelaar)
Attachment #594116 -
Flags: review?(jmuizelaar)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 594116 [details] [diff] [review]
Remove dead default cases in gfx
I'm not thrilled with the addition of MOZ_NOT_REACHED() but if gcc needs it so be it.
Attachment #594116 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 5•13 years ago
|
||
Comment on attachment 594116 [details] [diff] [review]
Remove dead default cases in gfx
Review of attachment 594116 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/thebes/gfxRect.h
@@ +130,2 @@
> }
> + MOZ_NOT_REACHED("Incomplet switch");
This should be "Incomplete switch". Here and elsewhere in this patch.
|
|
Assignee | |
Comment 6•13 years ago
|
||
A new combined patch is under test in
https://tbpl.mozilla.org/?tree=Try&rev=6c6023a4e8a3
I will push this one once the dependency is fixed.
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•