Closed
Bug 724538
Opened 13 years ago
Closed 9 years ago
use ICU implementations to replace much of intl/unicharutils
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
I expect that most (if not all) of the Unicode utilities in intl/unicharutils can be replaced by calls to ICU - either directly, or via lightweight wrappers if we want to maintain existing APIs for the rest of Gecko or for use by extensions, etc.
Comment 1•11 years ago
|
||
This does mean that every browser except Microsoft ends up with the same underlying implementation and bugs :/
Updated•11 years ago
|
Assignee | ||
Comment 2•9 years ago
|
||
We have already switched a few of the functions in nsUnicodeProperties over from our own data tables to ICU (in builds where ENABLE_INTL_API is defined).
We can trim a further 80K or so from libxul by using ICU property accessors to replace most of the data in the nsCharProps2 array.
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8692654 -
Flags: review?(smontagu)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8692655 -
Flags: review?(smontagu)
Assignee | ||
Updated•9 years ago
|
Attachment #8692654 -
Flags: review?(smontagu) → review?(VYV03354)
Assignee | ||
Updated•9 years ago
|
Attachment #8692655 -
Flags: review?(smontagu) → review?(VYV03354)
Updated•9 years ago
|
Attachment #8692654 -
Flags: review?(VYV03354) → review+
Updated•9 years ago
|
Attachment #8692655 -
Flags: review?(VYV03354) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e53666d77dc54ead9ca93c38041ebf7cfdb6848
Bug 724538 - When ICU is available in the build, replace most of nsCharProps2 fields with ICU property accessors. r=emk
https://hg.mozilla.org/integration/mozilla-inbound/rev/2038722d99d4d73a5ff508f20e51c7251c267a8d
Bug 724538 - Regenerate Unicode property data with updated script. r=emk
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e53666d77dc
https://hg.mozilla.org/mozilla-central/rev/2038722d99d4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•