Closed
Bug 72463
Opened 24 years ago
Closed 22 years ago
Sort by "order received" removed from pull-down menu
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: glazou, Assigned: neil)
References
Details
Attachments
(4 files, 2 obsolete files)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
sspitzer
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
Sort by "order received" seems to have been removed from pull-down menu
in the main mail/news window. See snapshot attached. "Order received" used
to be the last selectable choice after "Total".
I was using this feature all the time and deeply regrets it is now only
available through View > Sort By > Order Received.
Reporter | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
When the tree was converted to an outline control the Order Received column
was't transferred - I don't think this was intentional.
threadPane.xul also has some typos in it.
Assignee | ||
Comment 3•24 years ago
|
||
Comment 4•24 years ago
|
||
neil, thanks for the patch and for fixing those typos.
to get "order received" to work properly, there is a little more work involved.
I'll attach the patch to get sorting by order received to work.
(in my patch, I'm showing the message key id in the order received column)
all that is left is to hide the column by default.
accepting.
Status: NEW → ASSIGNED
Comment 5•24 years ago
|
||
Comment 6•24 years ago
|
||
two comments about that patch:
1) I need to figure out how to hide the "order received" column by default
2) I'm showing the id (a nsMsgKey) as the value in the column.
Comment 7•24 years ago
|
||
I've checked in the witdth -> width fix as part of another bug.
that would have fix the problem where we weren't persisting certain column widths.
Comment 8•24 years ago
|
||
This actually was intentional. The column doesn't do anything and only existed
because there was no previous way to add it to the menu without adding it to the
tree. I'd suggest not adding this back in.
Comment 9•24 years ago
|
||
ok, thanks for the info putterman.
I won't show the column. but, part of my fix is needed to make sure insertion
sorting still works when sorted by id.
a new patch on the way...
Reporter | ||
Comment 10•24 years ago
|
||
If you don't have the column or any other one-click UI element, it is impossible
to reverse the sort order... I was using that feature really often and I would
consider having to use a menu item hidden somewhere deep in "View" as a real
UI regression.
Comment 11•24 years ago
|
||
4.x had "ascending" and "descending" at the bottom of the "View | Sort by | ..."
that would allow you to reverse the sort, right?
jglick, should we add that back?
having it in the ui (and giving it access keys) might be necessary for
accessability and users who don't have a mouse.
Updated•24 years ago
|
QA Contact: esther → nbaca
Comment 12•24 years ago
|
||
We should have "ascending" and "descending" at the bottom of the "View | Sort by
..." menu.
Comment 13•24 years ago
|
||
marking won't fix. #72819 covers the "ascending" and "descending" menu items.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 14•24 years ago
|
||
I strongly disagree with this choice and proposes to re-insert a new optional
column in the
outliner containing the message number/index in the folder. Then it could be
possible to sort in ascending/descending order just clicking on the column's header.
Comment 15•24 years ago
|
||
reopening, until the discussion is complete.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment 16•24 years ago
|
||
First off, I'd like to say that this feature is _very_ important because of all
the timing differences between people's computers. Without this, entire mailing
lists are extremely hard for me to follow...
I definitely agree with Daniel, put the extra column back in. Putting an
ascending/descending option in View - Sort By is independent of this bug, since
it has to do with the other sorting methods as well.
I think the extra column AND the extra menus should be added, since I was under
the impression that there's two different "ways" to turn on features like this
in mozilla (mouse/keyboard).
PS I know this is off-topic big time, but I just wanted to say thanks for an
amazing piece of software (mail&news specifically). Without you guys I might
have had to use that other piece of **** out of Redmond.
Comment 17•24 years ago
|
||
I second daniel's suggestion for having a column with the message no. in it.
Mulberry does the same and I find it very useful. Also, the drop down menu iten
should definitely be added back. I;m voting for this bug. :)
Comment 18•24 years ago
|
||
I completely agree that this should be added back to the pull-down menu. Most
people will never even see that this feature is available without it being
there, and yet it is an EXTREMELY useful feature!
Comment 19•23 years ago
|
||
So whats happening with this bug? Is it going to be fixed sometime soon?
Comment 20•23 years ago
|
||
is there any particular reason that the "Date" field is used as a default column
at all? I can't think of why users would want to orginize their email by the
sender's date at all, unless all email was from one timezone/orginization, which
seems like a rare case.
it seems to me that "Received" should replace "Date" entirely, even if via a pref.
btw, I think Outlook and other email agents use "Received" as the default date
column.
Comment 21•23 years ago
|
||
I also believe this is important to fix, and in fact
"Order Received" should be the default. This is because
"Date" depends on the date sent, which is computed by the
sender's mail client based on the date set in
the sender's machine. Often senders' machines have dates
that are wildly wrong--even by years---and this has
led in the past to mail that's mis-categorized or
overlooked.
For me, View/Sort-By/Order-Received is easily the most
common function I use in mail/news, along with GetNewMail and
some other sort-by (like subject or sender).
Updated•23 years ago
|
QA Contact: nbaca → olgam
Comment 22•23 years ago
|
||
ping....
Whats happening with this bug? can we decided either way. That is either mark
this as WONTFIX or INVALID OR get the patch accepted.
Personally I think that the order received column is very helpful but thats just
me. Also having a Msg Number which fills up the order received column is a good
idea. Heck, you can even call it the "Msg#" column instead of Order Received if
that makes more sense. My personal opinion, fix this for 1.0. unless ofcourse
the majority of people say that this shouldn't be fixed. But from what I read,
its not the case.
Here's the deal. If I update the patch thats lying on this bug and submit, would
you guys accept it for 1.0?
Also platform/OS should be All/All.
Comment 23•23 years ago
|
||
I agree this is important. I cruise my IMAP mailbox in "order received,
descending" mode. At least several times a day, I click on thread, sender or
subject columns to group my mail into context. Then, to get back, I am
currently forced to use View > Sort By > Order Received and then View > Sort
By > Descending. A column would be bliss: click!
Comment 24•23 years ago
|
||
Another ping. This bug (and the patch) are well over a year old now! Please?
Comment 25•22 years ago
|
||
I agree. Sort by date received is be more useful, as spammers often forge the
sending date, and people's PC's often have the wrong time. I miss email ALL THE
TIME because it sorts to some weird place.
Comment 26•22 years ago
|
||
BTW this the OS for this bug should be set to "all" since it occurs on all
platforms.
Comment 27•22 years ago
|
||
*** Bug 161073 has been marked as a duplicate of this bug. ***
Comment 28•22 years ago
|
||
this patch removes "Order Received" menu item alltogether and adds a pref for
which date you want to sort by when you click on the 'Date' header or do
'View'/'Sort By'/'Date'.
add the mail.ignore_senders_date_for_sort pref to sort by 'Order Received'.
Comment 29•22 years ago
|
||
*** Bug 161073 has been marked as a duplicate of this bug. ***
Comment 30•22 years ago
|
||
I've been running with this patch for a few days now without a problem. anyone
else want to test this?
Comment 31•22 years ago
|
||
I'm happy to test it (its a great idea and the solution I was toying with a few
days ago before I noticed this bug), have a Win2K build (with one patch I have
just created including changes to a file you change: nsMsgDBView.cpp) but am new
to this cvs/diff/patch business -- how do I apply the patch (give my working
copy of nsMsgDBView.cpp is different?)
Comment 32•22 years ago
|
||
I'm happy to test it (its a great idea and the solution I was toying with a few
days ago before I noticed this bug), have a Win2K build (with one patch I have
just created including changes to a file you change: nsMsgDBView.cpp) but am new
to this cvs/diff/patch business -- how do I apply the patch (give my working
copy of nsMsgDBView.cpp is different?)
Comment 33•22 years ago
|
||
on unix:
# patch -p0 < patch_file
I'm not sure about windows...
Comment 34•22 years ago
|
||
*** Bug 166254 has been marked as a duplicate of this bug. ***
Comment 35•22 years ago
|
||
Just to add my $0.02 to this..
It's non-intuitive to, say, click on the 'Sender' column to sort by that column
when you're trying to locate an email from a particular individual, and then
have to go back to the menus to select the sort option for order received.
Every other field is available as a column heading - why is 'Order received'
not? (Incidentally, I'd note that this is a feature I've seen in pretty much
every other mail client I've ever used, and one that users tend to expect
without even thinking about it. If a user is going to move over, it's features
like this which shouldn't be missing).
Even if the column is only hidden by default, at the very least allow it to be
selected as a column by the user.
Comment 36•22 years ago
|
||
hi, i agree with comment #16: i don't understand why anyone would want to sort
based on the random clock that the sender's computer had.
i suggest replacing the Date field with "Date Received", adding a different
column with date received, or a pref to make the Date column be date received.
any of these would work for me.
Comment 37•22 years ago
|
||
*** Bug 175771 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 38•22 years ago
|
||
*** Bug 191769 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 39•22 years ago
|
||
Transferring owner from dup :-)
Assignee: sspitzer → neil
Status: REOPENED → NEW
Assignee | ||
Comment 40•22 years ago
|
||
Attachment #28111 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Attachment #114666 -
Flags: review?(sspitzer)
Comment 41•22 years ago
|
||
Comment on attachment 114666 [details] [diff] [review]
Proposed patch
r/sr=sspitzer on neils patch.
Attachment #114666 -
Flags: superreview+
Attachment #114666 -
Flags: review?(sspitzer)
Attachment #114666 -
Flags: review+
Comment 42•22 years ago
|
||
this is probably planned for 1.4.
before you land, a few questions / comments:
1) what about the search messages window?
2) also, where will this column appear for existing users? (hopefully, on the
far right in the thread pane)
also note, distributors should be able to hide this column by making a theme change.
Comment 43•22 years ago
|
||
Comment on attachment 114666 [details] [diff] [review]
Proposed patch
> 1) what about the search messages window?
I'm running with this change.
The column makes sense for single folder searches, but not much sense for
cross-folder searches.
if the user expects to search across folders and sort by order received, it
won't work.
> 2) also, where will this column appear for existing users? (hopefully, on the
> far right in the thread pane)
I'm thinking users should be able to add it, but it should be hidden by default
for new (and existing) users in both the thread pane and the search dialog.
(similar to some new folder pane columns, like "Size", that are relatively new
to the product.)
3)
the menu item and column picker is "Order Received" but the column header is
"ID". is this what we want?
I'm going to take back my r/sr until we resolve these issues.
Attachment #114666 -
Flags: superreview-
Attachment #114666 -
Flags: superreview+
Attachment #114666 -
Flags: review-
Attachment #114666 -
Flags: review+
Assignee | ||
Comment 44•22 years ago
|
||
1. Good catch - fixed.
2. It is hidden="true" by default.
If distributors have an overlay, they can add
<treecol id="idCol" ignoreincolumnpicker="true"/>
to stop people unhiding it, and optionally
#idCol { visibility: collapse; }
in case someone is sharing a profile with an enabled column
3. sspitzer 1.16 <!ENTITY idColumn.label "ID">
Need I say more ;-)
Attachment #114666 -
Attachment is obsolete: true
Comment 45•22 years ago
|
||
Comment on attachment 114796 [details] [diff] [review]
Addressed review comments
r/sr=sspitzer
I think I named it "ID" because it was used only by development (patrick beard)
can you change it to "Order Received" before checking in?
that's better than "ID".
Attachment #114796 -
Flags: superreview+
Attachment #114796 -
Flags: review+
Assignee | ||
Comment 46•22 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago → 22 years ago
Resolution: --- → FIXED
Comment 47•22 years ago
|
||
Maybe this should be a new bug/feature request, but I guess I mis-read this and
was under the impression that the idea of adding the received column was to add
received date, rather than an arbitrary index that is basically meaningless to
the end user. It achieves the same thing on a functional level, but I think
displaying received date makes more sense. I couldn't find an existing bug on
this. Comments?
Comment 48•22 years ago
|
||
James - well it's not the same as this bug, but you already filed it and it was
duped. as this bug doesn't show the received date, and there are other similar
comments here, I've reopened your bug 166254 as an enhancement request for a
date field.
the fix for this bug is certainly an improvement, and it seems to work fine in
yesterday's nightly.
Status: RESOLVED → VERIFIED
Comment 49•22 years ago
|
||
*** Bug 178097 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•