Closed
Bug 724740
Opened 13 years ago
Closed 13 years ago
Reparent children during bookmark folder deletion
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P1)
Tracking
(blocking-fennec1.0 beta+)
VERIFIED
FIXED
mozilla14
Tracking | Status | |
---|---|---|
blocking-fennec1.0 | --- | beta+ |
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
(Whiteboard: [sync])
Blocks the full version of Bug 723841.
Assignee | ||
Comment 1•13 years ago
|
||
Reasoning: if we process a deleted folder before we process all of its deleted children, then the deletion will fail due to consistency constraints, and the sync as a whole will fail. We need to queue deletions (Bug 724739), and handle the case of a folder being deleted without all of its children being deleted (this bug).
Updated•13 years ago
|
blocking-fennec1.0: --- → beta+
Updated•13 years ago
|
Whiteboard: [sync]
Updated•13 years ago
|
Assignee: nobody → ally
Assignee | ||
Updated•13 years ago
|
Assignee: ally → rnewman
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
This is nearly done (and also Bug 724739); just writing tests now.
Assignee | ||
Comment 3•13 years ago
|
||
Tests pass. Running a build to get some QA before I land this, because I don't want to have to back it out!
Assignee | ||
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla14
Comment 5•13 years ago
|
||
How do you delete a folder without deleting its children?
Comment 6•13 years ago
|
||
rnewman, please post the snippet you use to delete folder without touching its children.
Assignee | ||
Comment 7•13 years ago
|
||
(In reply to Tracy Walker [:tracy] from comment #6)
> rnewman, please post the snippet you use to delete folder without touching
> its children.
https://wiki.mozilla.org/Services/Sync/Snippets#Delete_and_restore_a_record
Comment 8•13 years ago
|
||
ok, got that working (I think). Now, what am I looking for on the mobile device or in logs?
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c2a06f36ba3
Not sure if I'm supposed to close this bug or not.
Assignee | ||
Comment 10•13 years ago
|
||
Thanks Ehsan!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Product: Mozilla Services → Android Background Services
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•