Closed
Bug 72506
Opened 24 years ago
Closed 24 years ago
disk cache needs efficient eviction and miss detection
Categories
(Core :: Networking: Cache, defect, P1)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla0.9
People
(Reporter: gordon, Assigned: gordon)
References
Details
(Whiteboard: [cache])
This will be fixed by implementing the disk cache record table.
Comment 1•24 years ago
|
||
one major problem and a few nits:
nsCache.cpp:
* unused #if defined(PR_LOGGING) at top of file
* what if CacheLogInit() were called twice?
nsCacheEntryDescriptor.cpp:
* you can remove redundant checking of |visitor| parameter
nsCacheService.cpp:
* might want to clean up tabbing on line 773
* might want to clean up tabbing on line 779
* nsCacheService::Shutdown() calls LogCacheStatistics() outside of #ifdef
nsMemoryCacheDevice.cpp:
* nsCRT::strlen(0) returns 0, so you can remove the redundant check
Comment 2•24 years ago
|
||
my comments apply to the DISKCACHE1_BRANCH as of 4/3/2001 17:40:05 PDT
Comment 3•24 years ago
|
||
sr=darin once the non- PR_LOGGING shutdown problem is fixed.
I've fixed all these except the redundant visitor check on the branch. I'll land
it as soon as the trees go green.
DISKCACHE1_BRANCH has landed. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•