Closed
Bug 725454
Opened 13 years ago
Closed 13 years ago
Hide bookmark folders if they are empty
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mfinkle, Assigned: Margaret)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
We show "Mobile" and "Desktop" folders in the Bookmarks list. We should probably hide those section headers if there are no bookmarks
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 1•13 years ago
|
||
I was hoping this would do the job, but it's just hiding the contents of the group headers, not completely hiding them, so there's an unwanted blank space with a gray border.
We could also do something more extensive, like check to see if there are mobile/desktop bookmarks when we're creating the MatrixCursor in BookmarksQueryTask, but I'm worried that will make listening for adding/removing bookmarks more difficult.
Assignee | ||
Comment 2•13 years ago
|
||
Brian, you might want to be aware of this bug as well. I'm hoping I can make a fix that won't affect you at all, though :)
Assignee | ||
Comment 3•13 years ago
|
||
While working on bug 722020, I discovered that you can't set a list item to View.GONE, but doing that to its children does the trick.
Hopefully we can land bug 722020 in the near future, which will remove the need for this, but we can land this in the interim.
Attachment #595605 -
Attachment is obsolete: true
Attachment #596352 -
Flags: review?(mark.finkle)
Reporter | ||
Comment 4•13 years ago
|
||
I am fine with WONTFIXing this and waiting for bug 722020
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #4)
> I am fine with WONTFIXing this and waiting for bug 722020
Sounds good to me.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•13 years ago
|
Attachment #596352 -
Flags: review?(mark.finkle)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•