Serge Gautherie (:sgautherie) Assignee
	Description • 13 years ago

2 changesets to port:
http://hg.mozilla.org/mozilla-central/rev/7769be27ba62
http://hg.mozilla.org/mozilla-central/rev/61e6d741bd54

Note:
Don't use 'arguments.callee' (anymore), add/use function names.

	Serge Gautherie (:sgautherie) Assignee
	Comment 1 • 13 years ago

NB: Bug 726530 is unaffected by this patch.

	Serge Gautherie (:sgautherie) Assignee
	Comment 2 • 13 years ago

Found while here...

	neil@parkwaycc.co.uk
	Comment 3 • 13 years ago

Comment on attachment 596609 [details] [diff] [review]
(Av1) Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey
[Checked in: Comment 11]

So, what's the point of the renames?

Also, when you write a function expression, the name of the function is only in scope inside the function itself, so you don't actually need to give your functions unique names. For instance, this is perfectly legal:

var foo = [ function foo() { return foo; } ];

	neil@parkwaycc.co.uk
	Comment 4 • 13 years ago

Comment on attachment 596610 [details] [diff] [review]
(Bv1) Some space/line-ending cleanup
[Checked in: See comment 5]

r=me to fix the line endings, but the trailing spaces aren't worth the time.

	Serge Gautherie (:sgautherie) Assignee
	Comment 5 • 13 years ago

Comment on attachment 596610 [details] [diff] [review]
(Bv1) Some space/line-ending cleanup
[Checked in: See comment 5]

http://hg.mozilla.org/comm-central/rev/c22269a950d7
Bv1, with comment 4 suggestion(s).

	Serge Gautherie (:sgautherie) Assignee
	Comment 6 • 13 years ago

(In reply to neil@parkwaycc.co.uk from comment #3)

> So, what's the point of the renames?

Just to match the Firefox names, as we did previously for other tests: to ease maintenance, as in spare me history searches each time I do bugs like this one.

> you don't actually need to give your functions unique names.

Yeah, but I thought it can't hurt to be more explicit than that.
Yet, if you don't want the numbering, I'll remove it.

	neil@parkwaycc.co.uk
	Comment 7 • 13 years ago

(In reply to Serge Gautherie from comment #6)
> (In reply to comment #3)
> > So, what's the point of the renames?
> Just to match the Firefox names, as we did previously for other tests
So the other three tests in the patch already use the Firefox name?

	Serge Gautherie (:sgautherie) Assignee
	Comment 8 • 13 years ago

(In reply to neil@parkwaycc.co.uk from comment #7)
> So the other three tests in the patch already use the Firefox name?

Yes: all Firefox tests live in
http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/

	Serge Gautherie (:sgautherie) Assignee
	Comment 9 • 13 years ago

(In reply to Serge Gautherie (:sgautherie) from comment #6)
> Yet, if you don't want the numbering, I'll remove it.

Just to confirm, should I check it in with/without numbering?

	neil@parkwaycc.co.uk
	Comment 10 • 13 years ago

(In reply to Serge Gautherie from comment #9)
> Just to confirm, should I check it in with/without numbering?
Yes, you can leave the numbering in.

	Serge Gautherie (:sgautherie) Assignee
	Comment 11 • 13 years ago

Comment on attachment 596609 [details] [diff] [review]
(Av1) Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey
[Checked in: Comment 11]

http://hg.mozilla.org/comm-central/rev/cff76f26dd7b