Stefan Reporter
	Description • 13 years ago

User Agent:  

Steps to reproduce:

1. Install and activate flashblock 1.5.15.1, tweak version checking if necessary.
2. Open http://www.youtube.com/watch?v=3fqBuo5JZoY
3. Click at play symbol.


Actual results:

3. Video does not start playing.


Expected results:

3. Start playing.

The first bad revision is:
changeset: 85853:15b00ab7f22d
user: Josh Aas <joshmoz@gmail.com>
date: Tue Jan 31 16:55:54 2012 -0500
summary: Bug 90268: Change plugin instance ownership from layout to content. r=roc r=bsmedberg

Regression: Bug 682951 - Youtube video does not start with flashblock

	Virgil Dicu [:virgil] [QA]
	Comment 1 • 13 years ago

Mozilla/5.0 (X11; Linux x86_64; rv:13.0a1) Gecko/20120207 Firefox/13.0a1
Mozilla/5.0 (Windows NT 6.1; rv:13.0a1) Gecko/20120215 Firefox/13.0a1

Confirmed with steps from comment 0.

	u279076
	Comment 2 • 13 years ago

Josh, can you have a look at this bug? Is it a regression to your fix? This sounds like it might be a bug in the add-on but I'm not sure.

	Steven Michaud [:smichaud] (Retired)
	Comment 3 • 13 years ago

Please test with today's nightlies.

Please also test with one of the builds at the following URL, which have my patch for bug 723520:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/smichaud@pobox.com-292c77354647/

	Stefan Reporter
	Comment 4 • 13 years ago

bad: nightly 2012-02-15-03-11-55-mozilla-central d45c7d7b0079
bad: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/smichaud@pobox.com-292c77354647/try-linux64/firefox-13.0a1.en-US.linux-x86_64.tar.bz2

	Steven Michaud [:smichaud] (Retired)
	Comment 5 • 13 years ago

Thanks, Stefan.

	Steven Michaud [:smichaud] (Retired)
	Comment 6 • 13 years ago

I can reproduce this bug, too, on OS X 10.6.8 (testing with today's mozilla-central nightly).  I won't be able to get to it for a while, though.

	Josh Aas Assignee
	Comment 7 • 13 years ago

A little debugging shows that we're starting the plugin instance just fine after clicking to play the video, and, as expected, we're sending an NPP_SetWindow message over IPC. Still not sure why the video doesn't play though.

	Philip Chee
	Comment 8 • 13 years ago

Very strange. My own self builds work:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120223 Firefox/13.0a1 
But downloaded nightlies from ftp.mozilla.org show this bug.

	tomko222
	Comment 9 • 13 years ago

I can confirm this bug too.
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:13.0) Gecko/20120223 Firefox/13.0a1

	her34her34
	Comment 10 • 13 years ago

I can confirm this bug too.

Error message:

Error: e.target.ownerDocument is undefined
Source File: chrome://flashblock/content/flashblock.js
Line: 267

	Ozsmeg
	Comment 11 • 13 years ago

Works fine if you add youtube.com to the flashblock whitelist.

	tomko222
	Comment 12 • 13 years ago

(In reply to Ozsmeg from comment #11)
> Works fine if you add youtube.com to the flashblock whitelist.

For example I use flash mainly to stop youtube autoplay so adding it to whitelist dont make sense for me...

	xtrem123
	Comment 13 • 13 years ago

agree with tomko222

	Alex Keybl [:akeybl]
	Comment 14 • 13 years ago

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20120301 Firefox/13.0a1

STR:

1) Install Flashblock and make sure it's enabled by default (I'm using 1.5.15.1)
2) Go to http://www.cbsnews.com/8301-3460_162-57390236/paul-limbaugh-apologized-for-personal-gain/
3) Click "PLAY CBS NEWS VIDEO"
4) Click Flashblock play button

Expected: video plays
Occurs: black box where Flash player is

	Danial Horton
	Comment 15 • 13 years ago

The issue is happening in reverse on dailymotion, video's are playing back when flashblock is enabled, no white listing has been set.

	Danial Horton
	Comment 17 • 13 years ago

So whats going on with this, it is a fairly painful regression, particular on a number of tabs that can put the containers memory use past 1GB 

Any potential work around in the go for flashblock itself?, the e.target.ownerDocument is undefined is kind of sus, I haven't seen that on any of the affected sites i visit.

	Philip Chee
	Comment 18 • 13 years ago

Neil suggested that I might need e.originalTarget in Flashblock instead but I'll need a reproducible test case to work on.

	Danial Horton
	Comment 19 • 13 years ago

Error: e.target.ownerDocument is undefined
Source file: chrome://flashblock/content/flashblock.js
Line: 267

when clicking the flashblock overlay on http://www.watchanimeon.com/naruto-shippuden-episode-253/

	Danial Horton
	Comment 20 • 13 years ago

Error: e.target.ownerDocument is undefined
Source file: chrome://flashblock/content/flashblock.js
Line: 267

when clicking the flash overlay on http://www.youtube.com/watch?v=JLdB0WEixjM

the watchanimeon flash video loads
the youtube video doesn't :|

	stevfe
	Comment 21 • 13 years ago

So is flashblock going to be fixed?

Firefox 13 is in aurora channel and problem is still there.

	Jim Jeffery not reading bug-mail 1/2/11
	Comment 22 • 13 years ago

New dev version here: http://downloads.mozdev.org/flashblock/flashblock-1.5.unstable.xpi 1.5.16a2
but it does not fix the problem.

http://flashblock.mozdev.org/installation1.html

	Josh Aas Assignee
	Comment 23 • 13 years ago

I did some debugging on Linux (FC16, trunk code) and here is what I think is going on.

After clicking the play button from Flashblock, the DOM node for the plugin instance is added to the document. It has a useless src/data attribute, about:home or about:blank (I don't remember). As a result of adding this node to the document we instantiate a plugin and kick off a stream for the useless src/data URI. Later on Flashblock fixes the src/data attribute on the instance DOM node. This calls nsObjectLoadingContent::LoadObject, which attempts to re-load the object since the URI is now different. The result is a call to nsObjectLoadingContent::AsyncStartPluginInstance, which returns early doing nothing because we already have an instance. Thus the real stream is never delivered to the plugin.

It would be best if the src/data attribute was set properly when the DOM node was added back to the document so the first instantiation was correct. I'm not sure if we ever supported reloading instances when the src/data URL changed, but that is the fix we'll probably have to make on our end if we need to.

	Philip Chee
	Comment 25 • 13 years ago

> After clicking the play button from Flashblock, the DOM node for the plugin instance is
> added to the document. It has a useless src/data attribute, about:home or about:blank
> (I don't remember). As a result of adding this node to the document we instantiate a
> plugin and kick off a stream for the useless src/data URI. Later on Flashblock fixes
> the src/data attribute on the instance DOM node.

I had to do this because a null src attribute causes OS/2 to crash. See the following snippet from flashblock.xml:

function flashblockSetTitle(current, placeholder, isStandalone) {
	// non-null "about:blank" value to prevent OS/2 crashing
	var fakeURI = "about:blank";

	Stefan Reporter
	Comment 26 • 13 years ago

(In reply to Josh Aas (Mozilla Corporation) from comment #24)
> Created attachment 607942 [details] [diff] [review]
> fix v1.0

Works like a charm, thx!

	Josh Aas Assignee
	Comment 28 • 13 years ago

try server run:

https://tbpl.mozilla.org/?tree=Try&rev=c1b7e9a3b7ed

	Johnny Stenback (:jst)
	Comment 29 • 13 years ago

Comment on attachment 608057 [details] [diff] [review]
fix v1.1 (add a test)

Stealing review, r=jst

	Jim Jeffery not reading bug-mail 1/2/11
	Comment 30 • 13 years ago

Try build fixed the issue for me.  Youtube, and the cbs new link from comment #14 now work as expected. 

Tested with Flashblock 1.5.16a2 latest 'unstable' developers build on win7 x64, win32 build

	Danial Horton
	Comment 31 • 13 years ago

i don't have time to check myself (my line is in the process of being repaired)
but can someone verify the chia player, dailymotions on site player (not the embed one) and the flash uploader for dailymotion?

	Josh Aas Assignee
	Comment 32 • 13 years ago

pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/d85d2f90b632

	Josh Aas Assignee
	Comment 33 • 13 years ago

Comment on attachment 608057 [details] [diff] [review]
fix v1.1 (add a test)

[Approval Request Comment]
Regression caused by (bug #): 90268
User impact if declined: Flasblock broken on high profile sites (YouTube), other web compat issues w/o Flashblock.
Testing completed (on m-c, etc.): Automated test checked in.
Risk to taking this patch (and alternatives if risky): 4/10
String changes made by this patch: None

	Ed Morley [:emorley]
	Comment 34 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/d85d2f90b632

	Ahmed Aly
	Comment 35 • 13 years ago

if this patch works without regressions i guess it should be back ported to gecko 13

	yiaghyku
	Comment 36 • 13 years ago

I guess the problem was with firefox. I tried looking at the patches to see what was wrong but couldn't make sense of it.

Would someone explain to a non-programmer what the problem was and how the patch fixes it?

	Ryan VanderMeulen [:RyanVM]
	Comment 37 • 13 years ago

Comments #23 and #25 explain the issue.

	yiaghyku
	Comment 38 • 13 years ago

Yes i've read the thread.

From what i can tell when the user wants to unblock the flash object, the flashblock addon changes the flash object address to trigger a flash object refresh from browser.

This has always worked in firefox until firefox 13. So i'm wondering what happened in firefox 13 that broke flashblock and how does the patch fix it?

	IU
	Comment 39 • 13 years ago

(In reply to yiaghyku from comment #38)
> So i'm wondering what happened in firefox 13 that broke flashblock...

Read bug 90268

	Alex Keybl [:akeybl]
	Comment 40 • 13 years ago

Comment on attachment 608057 [details] [diff] [review]
fix v1.1 (add a test)

[Triage Comment]
Since the risk evaluation here does not yet warrant considering backing out bug 90268, and this bug is critical to fix for our Flashbock users, let's land on Aurora 13.

	Alex Keybl [:akeybl]
	Comment 41 • 13 years ago

If you could also add the qawanted keyword with any testing that we can do to lower that 4/10 risk rating, it'd be greatly appreciated :)

	Josh Aas Assignee
	Comment 42 • 13 years ago

pushed to mozilla-aurora

http://hg.mozilla.org/releases/mozilla-aurora/rev/5c4189019bc1

	Simona Badau, Desktop QA
	Comment 44 • 13 years ago

Verified that YouTube and cbs videos play as expected on Firefox 13 beta 2 when Flashblock 1.5.15.1 and Flashblock 1.5.16a2 are installed.

Tested on Windows 7, Ubuntu 11.10 and Mac OS x 10.6 using the STR from the description and from Comment 14.

Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0

	Simona Badau, Desktop QA
	Comment 45 • 12 years ago

Verified on Firefox 14 beta 7 that the videos from YouTube and CBS play properly - used the STR from the Description while Flashblock 1.5.15.1 and Flashblock 1.5.16a2 were installed.

Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20100101 Firefox/14.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20100101 Firefox/14.0