Closed
Bug 727705
Opened 13 years ago
Closed 13 years ago
remove two copies of pageloader from m-c
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: k0scist, Assigned: k0scist)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Two copies of pageloader live in mozilla-central:
http://mxr.mozilla.org/mozilla-central/source/layout/tools/pageloader/
http://mxr.mozilla.org/mozilla-central/source/testing/tools/pageloader/
These should be eliminated (see
https://bugzilla.mozilla.org/show_bug.cgi?id=725414#c7 )
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #597678 -
Flags: review?(jmaher)
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Jeff Hammel [:jhammel] from comment #2)
> try: https://tbpl.mozilla.org/?tree=Try&rev=c04c2f5a6558
beh not quite that simple. Need to fix the makefiles too :/
Assignee | ||
Updated•13 years ago
|
Attachment #597678 -
Flags: review?(jmaher) → review-
Comment 4•13 years ago
|
||
Try run for c04c2f5a6558 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=c04c2f5a6558
Results (out of 14 total builds):
exception: 13
failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-c04c2f5a6558
Updated•13 years ago
|
Assignee: nobody → jhammel
Assignee | ||
Comment 5•13 years ago
|
||
ABICT, removal shouldn't affect anything else: http://mxr.mozilla.org/mozilla-central/search?string=pageloader Anyone see anything I miss?
Comment 6•13 years ago
|
||
looks good to me!
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #597678 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #599302 -
Flags: review?(jmaher)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [autoland]
Updated•13 years ago
|
Whiteboard: [autoland] → [autoland-in-queue]
Comment 8•13 years ago
|
||
Autoland Patchset:
Patches: 599302
Branch: mozilla-central => try
Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d3bb9da762dc
Try run started, revision d3bb9da762dc. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d3bb9da762dc
Comment 9•13 years ago
|
||
Comment on attachment 599302 [details] [diff] [review]
remove two copies of pageloader and update the Makefiles
Review of attachment 599302 [details] [diff] [review]:
-----------------------------------------------------------------
awesome
Attachment #599302 -
Flags: review?(jmaher) → review+
Comment 10•13 years ago
|
||
Try run for d3bb9da762dc is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=d3bb9da762dc
Results (out of 231 total builds):
exception: 12
success: 181
warnings: 23
failure: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d3bb9da762dc
Updated•13 years ago
|
Whiteboard: [autoland-in-queue]
Comment 11•13 years ago
|
||
Assignee | ||
Comment 12•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•