Closed Bug 728369 Opened 13 years ago Closed 13 years ago

MAPLE: flash content on youtube misplaces itself

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(blocking-fennec1.0 beta+)

Status:
VERIFIED FIXED
Milestone:
Firefox 14
Tracking Flags:
Tracking Status
blocking-fennec1.0 --- beta+

People

(Reporter: nhirata, Assigned: snorp)

References

Details

(Whiteboard: MAPLE [layout])

Attachments

(1 file)

Fix non-OpenGL plugin positioning on Android
(deleted), patch
blassey
: review+
Details | Diff | Splinter Review
1. go to www.youtube.com 2. click on a link to a youtube video 3. click to play a flash video Expected: flash plays in the flash content area in youtube Actual: it's off position Note: MAPLE 2/17/2012, Samsung Galaxy SII
not for MWC
Whiteboard: MAPLE mwc-demo → MAPLE
Whiteboard: MAPLE → MAPLE mwc-demo
Priority: -- → P3
Priority: P3 → P2
Whiteboard: MAPLE mwc-demo → MAPLE
Assignee: nobody → snorp
Assignee: snorp → nobody
blocking-fennec1.0: --- → beta+
Assignee: nobody → snorp
Whiteboard: MAPLE → MAPLE [gfx]
I believe this is either layout or plugin-related.
Whiteboard: MAPLE [gfx] → MAPLE [layout]
This still occurs on 3/13/2012 build.
Comment on attachment 605755 [details] [diff] [review] Fix non-OpenGL plugin positioning on Android Review of attachment 605755 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/GeckoApp.java @@ +2748,5 @@ > public void reset(int aX, int aY, int aWidth, int aHeight, ImmutableViewportMetrics aViewport) { > PointF origin = aViewport.getOrigin(); > > + x = mOriginalX = aX; > + y = mOriginalY = aY; I'd be happier and less confused if x and y were mX and mY.
Attachment #605755 - Flags: review?(blassey.bugs) → review+
(In reply to Brad Lassey [:blassey] from comment #5) > Comment on attachment 605755 [details] [diff] [review] > Fix non-OpenGL plugin positioning on Android > > Review of attachment 605755 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mobile/android/base/GeckoApp.java > @@ +2748,5 @@ > > public void reset(int aX, int aY, int aWidth, int aHeight, ImmutableViewportMetrics aViewport) { > > PointF origin = aViewport.getOrigin(); > > > > + x = mOriginalX = aX; > > + y = mOriginalY = aY; > > I'd be happier and less confused if x and y were mX and mY. You mean if x was mX? Unfortunately those are inherited from the AbsoluteLayout.LayoutParams. If you are referring to mOriginalX I think mX would actually be more confusing there...
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #6) > (In reply to Brad Lassey [:blassey] from comment #5) > > Comment on attachment 605755 [details] [diff] [review] > > I'd be happier and less confused if x and y were mX and mY. > > You mean if x was mX? Unfortunately those are inherited from the > AbsoluteLayout.LayoutParams. If you are referring to mOriginalX I think mX > would actually be more confusing there... Yup, I mean what I said. We can't change it though, so carry on.
(In reply to Brad Lassey [:blassey] from comment #7) > (In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #6) > > (In reply to Brad Lassey [:blassey] from comment #5) > > > Comment on attachment 605755 [details] [diff] [review] > > > I'd be happier and less confused if x and y were mX and mY. > > > > You mean if x was mX? Unfortunately those are inherited from the > > AbsoluteLayout.LayoutParams. If you are referring to mOriginalX I think mX > > would actually be more confusing there... > > Yup, I mean what I said. We can't change it though, so carry on. although super.x may be more clear. Or this.x.
(In reply to Brad Lassey [:blassey] from comment #8) > (In reply to Brad Lassey [:blassey] from comment #7) > > (In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #6) > > > (In reply to Brad Lassey [:blassey] from comment #5) > > > > Comment on attachment 605755 [details] [diff] [review] > > > > I'd be happier and less confused if x and y were mX and mY. > > > > > > You mean if x was mX? Unfortunately those are inherited from the > > > AbsoluteLayout.LayoutParams. If you are referring to mOriginalX I think mX > > > would actually be more confusing there... > > > > Yup, I mean what I said. We can't change it though, so carry on. > > although super.x may be more clear. Or this.x. Ok, I changed it to this.x.
https://hg.mozilla.org/mozilla-central/rev/f6a2ab827253
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Verified fixed on: Nightly 14.0a1 (2012-03-20) 20120320043530 Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: