Closed
Bug 729427
Opened 13 years ago
Closed 13 years ago
Incremental GC should mark filenames of newly allocated scripts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Updated•13 years ago
|
tracking-firefox13:
--- → +
We also need to mark whenever we look up a filename in the hashtable, since it's effectively a weak pointer.
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Bill McCloskey (:billm) from comment #1)
> We also need to mark whenever we look up a filename in the hashtable, since
> it's effectively a weak pointer.
My plan is to mark newly incremental filename entries under the incremental GC. The rest of cases should be covered by normal marking as the filename is never overwritten. But eventually I want to either remove them or at least turn them into atoms. My initial measurements shows that filename strings are atoms in about 10-15% cases so turning mostly ascii string into UTF16 char array + JSString header should not bloat memory match...
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #600089 -
Flags: review?(wmccloskey)
Comment on attachment 600089 [details] [diff] [review]
v1
Thanks.
Attachment #600089 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Updated•13 years ago
|
status-firefox13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•