Closed
Bug 730798
Opened 13 years ago
Closed 13 years ago
Incorrect order of items in live bookmarks in native menubar
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 731563
People
(Reporter: cers, Assigned: mak)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
image/png
|
Details |
The order of "Live Bookmark Loading..." and "Open <site>" should be reversed, such that Open is always on top, and the loaded items populate the same section as the load indicator.
Steps to reproduce:
1) subscribe to a feed using live bookmarks (in this example, http://www.squarefree.com/burningedge/)
2) click Bookmarks->Bookmarks Toolbar
3) hover over the added feed
Result:
While loading:
Live Bookmark Loading... (grayed out)
-------------------------------------
Open "The Burning Edge"
After loading:
-------------------------------------
Open "The Burning Edge"
2012-02-26 Trunk builds
(etc)
Expected result:
While loading:
Open "The Burning Edge"
-------------------------------------
Live Bookmark Loading... (grayed out)
After loading:
Open "The Burning Edge"
-------------------------------------
2012-02-26 Trunk builds
(etc)
Assignee | ||
Comment 1•13 years ago
|
||
my assumption is the usual bug with bindings in native menubar.
we should probably make _startMarker and _endMarker popup expando rather than relying on the binding.
Assignee: nobody → mak77
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Updated•13 years ago
|
Blocks: livemarksIO
Assignee | ||
Updated•13 years ago
|
Keywords: regression
Comment 2•13 years ago
|
||
The missing "Open all in tabs" / nonworking middle click, should be a part of this bug or a new one?
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Pablo Greco from comment #2)
> The missing "Open all in tabs" / nonworking middle click, should be a part
> of this bug or a new one?
I actually remove that on purpose, cause was adding too much complexity to the patch and its use-cases are limited. Btw, should be a new bug.
Comment 4•13 years ago
|
||
I'd actually consider solving this binding issue once and for all. It should be doable by using "visibility" rather than "display" for hiding the menubar.
This could hurt performance, in theory.
Assignee | ||
Comment 5•13 years ago
|
||
her, I actually found we already fixed this in the past, so I have to check what's up since that code should work still!
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/browserPlacesViews.js#322
Assignee | ||
Comment 6•13 years ago
|
||
fixing the ordering is trivial, though the whole native menubar binding is quite broken, it just doesn't update correctly :(
Assignee | ||
Comment 7•13 years ago
|
||
this fixes ordering, unfortunately, at least on Lion, the binding is completely broken so the livemark never populates and sticks to "Live bookmark loading"
Attachment #601982 -
Flags: review?(mano)
Assignee | ||
Comment 8•13 years ago
|
||
note in bug 731563 I basically rewrote the markers to make them a bit less error-prone.
Assignee | ||
Comment 9•13 years ago
|
||
Comment on attachment 601982 [details] [diff] [review]
patch v1.0
hm, at this point I prefer taking directly bug 731563, it just works better (once I figure out why sometimes Lion enforces scrollbox on the popups)
Attachment #601982 -
Flags: review?(mano)
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Updated•13 years ago
|
Attachment #601982 -
Attachment is obsolete: true
Assignee | ||
Comment 10•13 years ago
|
||
in the end, I'm just duping this, the issue is basically the same.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•