Gervase Markham [:gerv] Assignee
	Description • 13 years ago

We should remove the MPL 1.1, LGPL and GPL license texts, and replace them with the MPL 2 text (plus perhaps a note about LGPL and GPL compatibility, modelled on the one written for NSS in bug 716563). 

We can do this before switching all the code headers (bug 716478) - there's no legal problem with that, as MPL 1.1 allows distribution under later versions.

Gerv

	Gervase Markham [:gerv] Assignee
	Comment 1 • 13 years ago

Luis: can you sanity-check comment 0 before I go ahead with this?

Thanks :-)

Gerv

	Luis Villa [Outside Counsel; for non-law use luis@tieguy.org]
	Comment 2 • 13 years ago

That sounds correct to me. I would hope that the compatibility language is unnecessary or could perhaps be addressed in the FAQ?

	Gervase Markham [:gerv] Assignee
	Comment 3 • 13 years ago

Yep, OK, we can link to the FAQ.

Gerv

	Gervase Markham [:gerv] Assignee
	Comment 4 • 13 years ago

This switches to MPL 2, adding a link to the FAQ, corrects a few inaccuracies about what license applies to what, and also makes the document validate as HTML5.

Gerv

	Luis Villa [Outside Counsel; for non-law use luis@tieguy.org]
	Comment 5 • 13 years ago

Comment on attachment 601235 [details] [diff] [review]
Patch v.1

Review of attachment 601235 [details] [diff] [review]:
-----------------------------------------------------------------

The pedant in me says that all the name -> id changes should be in a different commit, but otherwise this looks fine to me.

	Luis Villa [Outside Counsel; for non-law use luis@tieguy.org]
	Comment 6 • 13 years ago

Comment on attachment 601235 [details] [diff] [review]
Patch v.1

I am afraid that I am unable to figure out how to formally r+ this in the UI, but as plain-old-text, here is an r+.

	Gervase Markham [:gerv] Assignee
	Comment 7 • 13 years ago

Comment on attachment 601235 [details] [diff] [review]
Patch v.1

Click "Details", then change the "review" flag to "+".

Gerv

	Gervase Markham [:gerv] Assignee
	Comment 8 • 13 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/beb93f812874

Gerv

	Matt Brubeck (:mbrubeck)
	Comment 9 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/beb93f812874

	Daniel C
	Comment 10 • 13 years ago

The link to the MPL section doesn't work because about:license#mpl doesn't exist as a named anchor.

	Gervase Markham [:gerv] Assignee
	Comment 11 • 13 years ago

djcater: thanks; fixed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc874873ea21

Gerv

	Daniel C
	Comment 12 • 13 years ago

(In reply to Gervase Markham [:gerv] from comment #11)
> djcater: thanks; fixed.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/fc874873ea21
> 
> Gerv

    1.48 +        <li><span class="path">msvc*.dll</span> (C and C++ runtime libraries)</li>

Why did that need to be added?

Shouldn't the Microsoft changes be reviewed and checked in separately (in a different bug)? You've changed the name of the licence, the layout of it, and the files it covers all under the commit comment of "Add "mpl" anchor.".

	Gervase Markham [:gerv] Assignee
	Comment 13 • 13 years ago

Oops. That is a patch for a different bug. I'll work on a backout.

Gerv

	Gervase Markham [:gerv] Assignee
	Comment 14 • 13 years ago

There we go:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a66cd5f0790e

That's better. Thanks!

Gerv

	Marco Bonardo [:mak]
	Comment 15 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/fc874873ea21

	Marco Bonardo [:mak]
	Comment 16 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/a66cd5f0790e