Closed
Bug 730840
Opened 13 years ago
Closed 13 years ago
Use getBrowserURL() in Firefox tests to ease porting them, part 2
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 15
People
(Reporter: sgautherie, Assigned: raymondlee)
References
()
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #717963 +++
"Found 4 matching lines in 3 files"
|
Reporter | |
Updated•13 years ago
|
|
Assignee | |
Comment 1•13 years ago
|
||
Updated to use getBrowserURL in browser tests.
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 618578 [details] [diff] [review]
v1
Could you fix new
/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_lastpbcontextexited.js
* line 40 -- let newWin = window.openDialog("chrome://browser/content/", "_blank", "chrome,all,dialog=no");
too?
Attachment #618578 -
Flags: feedback+
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 618578 [details] [diff] [review]
> v1
>
> Could you fix new
>
> /browser/components/privatebrowsing/test/browser/
> browser_privatebrowsing_lastpbcontextexited.js
> * line 40 -- let newWin = window.openDialog("chrome://browser/content/",
> "_blank", "chrome,all,dialog=no");
>
> too?
Done.
Attachment #618578 -
Attachment is obsolete: true
Attachment #618595 -
Flags: review?(dao)
Attachment #618578 -
Flags: review?(dao)
|
|
Reporter | |
Updated•13 years ago
|
Attachment #618595 -
Flags: feedback+
|
||
Updated•13 years ago
|
Attachment #618595 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #618595 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 618949 [details] [diff] [review]
Patch for checkin
Passed Try
https://tbpl.mozilla.org/?tree=Try&rev=ef5f8d617329
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
|
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 8•13 years ago
|
||
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug][mentor=sgautherie][lang=js]
You need to log in
before you can comment on or make changes to this bug.
Description
•