Closed Bug 730849 Opened 13 years ago Closed 13 years ago

Port |Bug 613588 - (livemarksIO) Replace livemarks with asynchronous load-on-demand livemarks (was: Livemarks cause synchronous I/O during txul)| to SeaMonkey, tests

Categories

(SeaMonkey :: Bookmarks & History, defect, P2)

Tracking

(seamonkey2.10 verified)

VERIFIED FIXED
seamonkey2.11
Tracking Status
seamonkey2.10 --- verified

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fixed in SM2.10: Av1, Bv1-a210; SM 2.11: Bv1] [perma-orange])

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #730837 +++ New SeaMonkey failures on mochitest-browser-chrome: { TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/places/tests/browser_457473_no_copy_guid.js | Exception thrown - [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.undoTransaction]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource:///modules/PlacesUIUtils.jsm :: <TOP_LEVEL> :: line 1396" data: no] TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/places/tests/browser_library_views_liveupdate.js | Node is recognized as a livemark TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/places/tests/browser_library_views_liveupdate.js | Node is recognized as a livemark TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/places/tests/browser_library_views_liveupdate.js | Node is recognized as a livemark } There may be more on other suites. *** Need to port: *Tests: https://hg.mozilla.org/mozilla-central/rev/4814a8d64b8d In this case, I'm going to port tests before code (bug 730837).
Blocks: SmTestFail
Whiteboard: [perma-orange]
Whoever reviews it first... I did not update http://mxr.mozilla.org/comm-central/find?string=test_bookmarks_html.js yet, as that file seems to need other sync' before this one.
Attachment #600955 - Flags: review?(iann_bugzilla)
Attachment #600955 - Flags: review?(bugspam.Callek)
Comment on attachment 600955 [details] [diff] [review] (Av1) Update tests now that livemarks are asynchronous [Checked in: Comment 5] PS: This is 99% copy+paste (with 2+ nits), nothing SM specific.
Blocks: 730752
Depends on: 731663
(In reply to Serge Gautherie (:sgautherie) from comment #1) > http://mxr.mozilla.org/comm-central/find?string=test_bookmarks_html.js > yet, as that file seems to need other sync' before this one. I filed bug 731663.
Blocks: 732027
Comment on attachment 600955 [details] [diff] [review] (Av1) Update tests now that livemarks are asynchronous [Checked in: Comment 5] seems right to me r=me
Attachment #600955 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 600955 [details] [diff] [review] (Av1) Update tests now that livemarks are asynchronous [Checked in: Comment 5] http://hg.mozilla.org/comm-central/rev/949f8b97b255
Attachment #600955 - Attachment description: (Av1) Update tests now that livemarks are asynchronous → (Av1) Update tests now that livemarks are asynchronous [Checked in: Comment 5]
Attachment #600955 - Flags: review?(bugspam.Callek)
(In reply to Serge Gautherie (:sgautherie) from comment #5) > http://hg.mozilla.org/comm-central/rev/949f8b97b255 http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1330742797.1330747356.24459.gz Linux comm-central-trunk debug test mochitest-other on 2012/03/02 18:46:37 + http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1330744452.1330748114.25476.gz Linux comm-central-trunk debug test xpcshell on 2012/03/02 19:14:12 V.Fixed wrt this patch (only).
Trivial copy+paste. (Untested.)
Attachment #607037 - Flags: review?(iann_bugzilla)
Attachment #607037 - Flags: approval-comm-aurora?
Attachment #607037 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 607037 [details] [diff] [review] (Bv1) Update test_bookmarks_html.js now that livemarks are asynchronous [Checked in: Comment 8] http://hg.mozilla.org/comm-central/rev/58b62bf5edf3
Attachment #607037 - Attachment description: (Bv1) Update test_bookmarks_html.js now that livemarks are asynchronous → (Bv1) Update test_bookmarks_html.js now that livemarks are asynchronous [Checked in: Comment 8]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [perma-orange] → [fixed in SM2.10: Av1] [perma-orange]
Target Milestone: seamonkey2.10 → seamonkey2.11
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332414995.1332418388.9262.gz WINNT 5.2 comm-central-trunk debug test xpcshell on 2012/03/22 04:16:35 V.Fixed
Status: RESOLVED → VERIFIED
Comment on attachment 607037 [details] [diff] [review] (Bv1) Update test_bookmarks_html.js now that livemarks are asynchronous [Checked in: Comment 8] Test Only. a=me
Attachment #607037 - Flags: approval-comm-aurora? → approval-comm-aurora+
Keywords: checkin-needed
Whiteboard: [fixed in SM2.10: Av1] [perma-orange] → [c-n: 58b62bf5edf3 to c-a] [fixed in SM2.10: Av1] [perma-orange]
Is there a dependancy on this test I'm not aware of? $ hg qpush applying 730849-Bv1_test_bookmarks_html.diff patching file suite/common/places/tests/unit/test_bookmarks_html.js Hunk #1 FAILED at 112 Hunk #2 FAILED at 134 Hunk #3 FAILED at 160 Hunk #4 FAILED at 218 Hunk #5 FAILED at 252 Hunk #6 FAILED at 337 Hunk #7 FAILED at 365 7 out of 7 hunks FAILED -- saving rejects to file suite/common/places/tests/unit/test_bookmarks_html .js.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh 730849-Bv1_test_bookmarks_html.diff
patching file suite/common/places/tests/unit/test_bookmarks_html.js Hunk #3 FAILED at 163 Hunk #5 FAILED at 259 2 out of 7 hunks FAILED Removing c-n request for the moment.
Keywords: checkin-needed
Whiteboard: [c-n: 58b62bf5edf3 to c-a] [fixed in SM2.10: Av1] [perma-orange] → [fixed in SM2.10: Av1] [perma-orange]
After bug 731663 Cv1-SM-a210 landed: patching file suite/common/places/tests/unit/test_bookmarks_html.js Hunk #3 FAILED at 163 1 out of 7 hunks FAILED
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #13) > patching file suite/common/places/tests/unit/test_bookmarks_html.js > Hunk #3 FAILED at 163 > 1 out of 7 hunks FAILED That's because bug 736547 landed on c-c out of order...
Keywords: checkin-needed
Whiteboard: [fixed in SM2.10: Av1] [perma-orange] → [c-n: Bv1-a210 to c-a] [fixed in SM2.10: Av1] [perma-orange]
Comment on attachment 617229 [details] [diff] [review] (Bv1-a210) Update test_bookmarks_html.js now that livemarks are asynchronous [Checkin: Comment 15] http://hg.mozilla.org/releases/comm-aurora/rev/a86f9d4fc2a7
Attachment #617229 - Attachment description: (Bv1-a210) Update test_bookmarks_html.js now that livemarks are asynchronous → (Bv1-a210) Update test_bookmarks_html.js now that livemarks are asynchronous [Checkin: Comment 15]
(No idea about whiteboard and flags here, please check and handle yourself.)
Keywords: checkin-needed
Whiteboard: [c-n: Bv1-a210 to c-a] [fixed in SM2.10: Av1] [perma-orange] → [fixed in SM2.10: Av1] [perma-orange]
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1335230145.1335233640.17596.gz OS X 10.5 comm-aurora debug test xpcshell on 2012/04/23 18:15:45 s: cb-sea-miniosx01 seamonkey2.10: verified.
Whiteboard: [fixed in SM2.10: Av1] [perma-orange] → [fixed in SM2.10: Av1, Bv1-a210; SM 2.11: Bv1] [perma-orange]
No longer blocks: 730752
Blocks: 730752
No longer blocks: 732027
No longer depends on: SM-livemarksIO
Depends on: SM-livemarksIO
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: