I created one product with 1000 components, which is not so uncommon (think RedHat, who probably has several hundreds of components for some products), and now $user->get_enterable_products() is terribly slow, around 3 seconds on my machine. This method is used by $bug->choices to determine which products to list in the product field in show_bug.cgi, making each bug very slow to load in the web browser. The culprit is this query: $enterable_ids = $dbh->selectcol_arrayref( 'SELECT DISTINCT products.id FROM products INNER JOIN components ON components.product_id = products.id INNER JOIN versions ON versions.product_id = products.id WHERE products.id IN (' . join(',', @$enterable_ids) . ') AND components.isactive = 1 AND versions.isactive = 1');

It now takes 0.03 second instead of 3 seconds. 100 times faster. :)

Comment on attachment 601129 [details] [diff] [review] patch, v1 Review of attachment 601129 [details] [diff] [review]: ----------------------------------------------------------------- ::: Bugzilla/User.pm @@ +1036,5 @@ > # And all of these products must have at least one component > # and one version. > $enterable_ids = $dbh->selectcol_arrayref( > + 'SELECT DISTINCT products.id FROM products > + WHERE products.id IN (' . join(',', @$enterable_ids) . ') You have to use sql_in here, or Oracle will break.

FYI, with this patch, it now takes 4 seconds to load a bug report on my machine instead of 7 seconds. :)

mkanat: do you think that such a perf win could justify a backport to 4.0 despite this branch is now restricted to security fixes only since last week? It's a major performance win, and not just a theoretical edge case. We are talking about several seconds here. But I'm fine with a "no, it's too late" too. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/User.pm Committed revision 8135. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/ modified Bugzilla/User.pm Committed revision 8040.

(In reply to Frédéric Buclin from comment #0) > I created one product with 1000 components, which is not so uncommon (think > RedHat, who probably has several hundreds of components for some products), When I left Red Hat over a year ago, Fedora product had 6000+ components and each of the RHEL products had 3000+ so not uncommon. dkl