Closed
Bug 731313
Opened 13 years ago
Closed 13 years ago
Session Store is used even though lots of time has passed
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 722409
People
(Reporter: dougt, Assigned: lucasr)
Details
Attachments
(1 file)
(deleted),
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
If I crash in Fennec, then restart Fennec a long time later, session store restores all of my tabs. After some period of time, the tabs that fennec restores are not as important as they were once. I propose that we do not use session store after n minutes after a unexpected exit of Firefox.
Reporter | ||
Updated•13 years ago
|
Attachment #601327 -
Attachment is patch: true
Attachment #601327 -
Flags: review?
Reporter | ||
Comment 1•13 years ago
|
||
ian says 60m not 5.
Comment 2•13 years ago
|
||
Comment on attachment 601327 [details] [diff] [review]
patch v.1
A few changes:
+ long datetime = sessionFile.lastModified();
+ Date d = new Date(datetime);
Can be made as :
Date lastModified = new Date(sessionFile.lastModified());
Date aBitAgo can be renamed to expiryInterval ?
"if (lastModified.after(expiryInterval))" would feel more readable.
Log.w(LOGTAG, "zerdatime " + SystemClock.uptimeMillis() + " - finish check sessionstore.js exists");
-- This log would be misleading if we are not restoring session. Moving it when we assign hasSession to be true would be better.
r+ with these changes.
Attachment #601327 -
Flags: review? → review+
Reporter | ||
Comment 3•13 years ago
|
||
lucas, you are working on something like this, right?
Assignee: doug.turner → lucasr.at.mozilla
Reporter | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #3)
> lucas, you are working on something like this, right?
Yes, I just need to rebase my patch with latest m-c.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•