Closed Bug 73156 Opened 24 years ago Closed 24 years ago

Pressing <Enter> or <Return> does not open message

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: wesleyg, Assigned: sspitzer)

Details

(Keywords: regression, Whiteboard: [nsbeta1+])

Attachments

(1 file)

<summary> Pressing <Enter> or <Return> does not open message <repro environment> build 03-21-04 + Win2000 build 03-21-04 + Mac OS 9.04 <repro steps> -open mail -click on a message in any folder -press <Enter> or <Return> key <result> nothing happens <expected result> message opens in its own window Note: double clicking the message causes it to open
QA Contact: esther → laurel
Blocks: 68550
Keywords: mozilla0.9
No longer blocks: 68550
Note to QA: when fixed, check in search messages ui, too.
Keywords: nsbeta1, regression
cc'ing hyatt and marking nsbeta1+
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
This just needs to be hooked up in that outliner's keypress handler; I assume it got lost in the tree -> outliner switch. Outliner (like its tree predecessor) can't really be expected to guess what you want to happen on enter, unless we wanted to try to be really clever.
Attached file patch for bug (deleted) —
The patch I attached should fix it. It made it work in both the threadpane and search window for me. I just made it do the same as a double click.
nice job, sr=sspitzer I'll check it in for you when I land next.
fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I don't think you should hardcode the enter like that (comparing with keychar 13), instead, try to check if the keycode is VK_ENTER which is i18n safe.
Not that this makes it correct, but I was basing this on the other trees in the product (bookmarks, history) which also hardcode 13. If VK_ENTER is preferred, it's an easy enough fix. While I'm here, I notice that hitting Enter now acts like dbl click which not only opens a new window but also opens/closes a thread. Given that many trees want to override Enter and that the left and right arrow keys also expand/collapse items with children, maybe Enter and Double click should no longer do this?
i've got changes to switch to using VK_ENTER and VK_RETURN, I'll get them reviewed and checked in.
OK using apr16 commercial trunk build: linux rh6.2, mac OS 9.0, win98
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: