Closed
Bug 731929
Opened 13 years ago
Closed 13 years ago
IonMonkey: Failing jaeger/bug597871.js
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Segfault, looks like a regression from my iterator patch.
|
Assignee | |
Comment 1•13 years ago
|
||
Bleh. Bug is, if we call CloseIterator from JIT, IonActivation::savedEnumerators will be out of date. So this patch just updates the saved value.
Attachment #602228 -
Flags: review?(luke)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 602228 [details] [diff] [review]
fix
Alternatively, you could name it popSavedEnumerator() and have it assert that ion->savedEnumerator->prev == cx->enumerator before popping. (I'm not sure if that property holds.)
Attachment #602228 -
Flags: review?(luke) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•