Closed
Bug 73234
Opened 24 years ago
Closed 23 years ago
nsInputStreamChannel needs to forward itself as the request in progress events
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla0.9.1
People
(Reporter: darin.moz, Assigned: rpotts)
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
nsInputStreamChannel needs to forward itself as the request in progress events
(eg. nsHTTPChannel implements nsIProgressEventSink on behalf of the socket
transport).
|
||
Updated•24 years ago
|
Blocks: 64833
Keywords: mozilla0.9
|
Reporter | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
|
|
Reporter | |
Comment 1•24 years ago
|
||
|
|
Reporter | |
Comment 2•24 years ago
|
||
dougt, rpotts: can you review this patch? thx!
|
||
Comment 3•24 years ago
|
||
it looks fine. sr=dougt.
|
Assignee | |
Comment 4•24 years ago
|
||
looks good... r=rpotts
-- rick
|
|
Reporter | |
Comment 5•24 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•23 years ago
|
||
Guess what... the patch was wrong :-(
i'm reopening this one, so I cna make sure that it gets fixed...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•23 years ago
|
||
-> rpotts... I want to make sure that this gets in for 0.9.1
|
|
||
Comment 8•23 years ago
|
||
why is it wrong? / what did it break?
|
|
Assignee | |
Comment 9•23 years ago
|
||
|
|
Assignee | |
Comment 10•23 years ago
|
||
I've just attached a new patch to the old patch which correctly passes the
nsInputStreamChannel out as the request - rather than the underlying transport
request...
When the transport request was passed out, the progress info would be ignored by
the DocLoader because it did not recognize the request - ie. an OnStartRequest()
for the request had not been fired (only the OnProgress...)
|
|
Reporter | |
Comment 11•23 years ago
|
||
r/sr=darin
|
|
Assignee | |
Comment 12•23 years ago
|
||
I'll check this in asw soon as I get an a= and the tree opens :-)
|
|
||
Comment 13•23 years ago
|
||
r=valeski
|
|
Assignee | |
Comment 14•23 years ago
|
||
blah...
Assignee: darin → rpotts
Status: REOPENED → NEW
Keywords: mozilla0.9 → mozilla0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
|
||
Comment 15•23 years ago
|
||
a= asa@mozilla.org for checkin to 0.9.1 (on behalf of drivers).
|
|
Assignee | |
Comment 16•23 years ago
|
||
fix checked in...
Status: NEW → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•