Closed
Bug 73254
Opened 24 years ago
Closed 24 years ago
images aren't printing full size
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: sujay, Assigned: pavlov)
References
()
Details
(Whiteboard: [imglib])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
using 3/23 build of netscape
1) launch netscape
2) jump to http://www.mapquest.com
3) enter driving directions
4) print them out
notice the big map below driving directions prints out very small.
should be full size...
also happens for printing out simple 640x480 GIFS.
another sample URL:
http://www.vinod.com/cj.jpg
load it in browser then print..
notice the small size.
Keywords: nsbeta1
Updated•24 years ago
|
Whiteboard: [imglib]
Updated•24 years ago
|
Comment 6•24 years ago
|
||
The problem occurs with intrinsically sized images (I.E no width or height
specified) If a width or height is specified the images print with the correct
size.
If you print test2.html on WIN32 you will notice that the raptor.jpg is printed
at it's intrinsic size. (Which is tiny). If you specify a width and height for
the raptor.jpg image element it will print correctly.
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
the top part of this patch is what really fixes the bug here. the rest of it is
mostly just null checks.
basically, i have to convert from twips to "scaled" twips so that the image goes
through the scaling code when drawing.
Comment 10•24 years ago
|
||
r=timeless
Assignee | ||
Updated•24 years ago
|
Comment 12•24 years ago
|
||
+ if (intrinsicScaledHeight != 0) {
+ newHeight = (intrinsicScaledHeight * newWidth) / intrinsicScaledWidth;
Shouldn't that be
+ if (intrinsicScaledWidth != 0) {
^^^^^
...?
Similarly with:
+ if (intrinsicScaledWidth != 0) {
+ newWidth = (intrinsicScaledWidth * newHeight) / intrinsicScaledHeight;
Is there a bug # for:
+ // XXX need to handle low image...
...?
Fix those, and r=hixie
Keywords: patch
Target Milestone: mozilla0.9 → ---
Comment 13•24 years ago
|
||
(fixing mid air collision)
Nice to see the reviewers and superreviewers were so thorough. No rubber
stamping here. No sir.
Keywords: patch
Target Milestone: --- → mozilla0.9
Assignee | ||
Comment 14•24 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•24 years ago
|
||
*** Bug 75425 has been marked as a duplicate of this bug. ***
Comment 16•24 years ago
|
||
Verified fixed on Windows NT build 2001041704
Verified fixed on Mac build 2001041704, can't
verify on Linux 'cause of bug 75436
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•