Closed
Bug 732970
Opened 13 years ago
Closed 13 years ago
fix thinko in persistent telemetry merge
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
(deleted),
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
We have:
getHistograms: function getHistograms() {
let hls = Telemetry.histogramSnapshots;
but later on:
if (havePreviousSession) {
payloadObj.histograms = this.getHistograms(this._prevSession.snapshots);
}
else {
payloadObj.simpleMeasurements = getSimpleMeasurements();
payloadObj.histograms = this.getHistograms(Telemetry.histogramSnapshots);
which is clearly not winning. Earlier versions of the persistent telemetry stuff did the right thing, so this is the result of some bad merge-fu.
|
Assignee | |
Comment 1•13 years ago
|
||
Straightforward patch. I love JavaScript.
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [autoland-try:-b do -p all -u xpcshell -t none]
|
||
Updated•13 years ago
|
Whiteboard: [autoland-try:-b do -p all -u xpcshell -t none] → [autoland-in-queue]
|
|
||
Comment 2•13 years ago
|
||
Autoland Patchset:
Patches: 602934
Branch: mozilla-central => try
Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d089d32dd6b4
Try run started, revision d089d32dd6b4. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d089d32dd6b4
|
|
||
Comment 3•13 years ago
|
||
Try run for d089d32dd6b4 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=d089d32dd6b4
Results (out of 28 total builds):
success: 23
warnings: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d089d32dd6b4
|
|
||
Updated•13 years ago
|
Whiteboard: [autoland-in-queue]
|
||
Updated•13 years ago
|
Attachment #602934 -
Flags: review?(taras.mozilla) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•