Closed
Bug 733358
Opened 13 years ago
Closed 13 years ago
OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown
Categories
(Core :: Widget, defect)
Tracking
()
VERIFIED
DUPLICATE
of bug 732368
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 obsolete file)
observers of OBSERVER_TOPIC_IDLE_DAILY can access the disk. This was found by trying to add an assert: https://tbpl.mozilla.org/?tree=Try&rev=291bc14461c2
We could change the observers, but since we want to speed up shutdown anyway we should probably just avoid sending OBSERVER_TOPIC_IDLE_DAILY during shutdown.
Quoting taras recent email to dev-platform: "Notifications not useful during shutdown should be culled".
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → respindola
Attachment #603247 -
Flags: review?(mak77)
Comment 2•13 years ago
|
||
you are duplicating efforts with Mike (see bug 732368), please coordinate for a coalesced patch
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 603247 [details] [diff] [review]
OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown
[Moved to bug 732368]
Mike, would you mind commenting on this patch? I looked at yours and don't understand why you are doing the extra work.
As part of the exit(0) work we will be making the profile-* messages the ones we shutdown on and not even sending the xpcom messages.
I did a combined try run with this patch and the assert that found the issue (for me at lest) and it works:
https://tbpl.mozilla.org/?tree=Try&rev=fda958936a08
Attachment #603247 -
Flags: feedback?(mozstuff)
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Comment 5•13 years ago
|
||
V.Duplicate
Updated•13 years ago
|
Attachment #603247 -
Attachment description: OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown → OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown
[Moved to bug 732368]
Attachment #603247 -
Attachment is obsolete: true
Attachment #603247 -
Flags: review?(mak77)
Attachment #603247 -
Flags: feedback?(mozstuff)
You need to log in
before you can comment on or make changes to this bug.
Description
•