Closed Bug 733358 Opened 13 years ago Closed 13 years ago

OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown

Categories

(Core :: Widget, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED DUPLICATE of bug 732368

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 obsolete file)

observers of OBSERVER_TOPIC_IDLE_DAILY can access the disk. This was found by trying to add an assert: https://tbpl.mozilla.org/?tree=Try&rev=291bc14461c2 We could change the observers, but since we want to speed up shutdown anyway we should probably just avoid sending OBSERVER_TOPIC_IDLE_DAILY during shutdown. Quoting taras recent email to dev-platform: "Notifications not useful during shutdown should be culled".
you are duplicating efforts with Mike (see bug 732368), please coordinate for a coalesced patch
Comment on attachment 603247 [details] [diff] [review] OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown [Moved to bug 732368] Mike, would you mind commenting on this patch? I looked at yours and don't understand why you are doing the extra work. As part of the exit(0) work we will be making the profile-* messages the ones we shutdown on and not even sending the xpcom messages. I did a combined try run with this patch and the assert that found the issue (for me at lest) and it works: https://tbpl.mozilla.org/?tree=Try&rev=fda958936a08
Attachment #603247 - Flags: feedback?(mozstuff)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
V.Duplicate
No longer blocks: 662444, 721582
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
Attachment #603247 - Attachment description: OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown → OBSERVER_TOPIC_IDLE_DAILY can be sent during shutdown [Moved to bug 732368]
Attachment #603247 - Attachment is obsolete: true
Attachment #603247 - Flags: review?(mak77)
Attachment #603247 - Flags: feedback?(mozstuff)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: