Closed
Bug 733674
Opened 13 years ago
Closed 13 years ago
B2G SMS: Fix off-by-one errors in timestamp computation
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
Don't know what I was smoking at the time, but that code definitely ain't right, as jstraus points out:
let year = this.readSwappedNibbleBCD(1) + PDU_TIMESTAMP_YEAR_OFFSET;
let month = this.readSwappedNibbleBCD(1) - 1;
let day = this.readSwappedNibbleBCD(1) - 1;
let hour = this.readSwappedNibbleBCD(1) - 1;
let minute = this.readSwappedNibbleBCD(1) - 1;
let second = this.readSwappedNibbleBCD(1) - 1;
year and month are correct, the rest isn't.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #603606 -
Flags: review?(kyle)
|
||
Updated•13 years ago
|
Attachment #603606 -
Flags: review?(kyle) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•