Closed Bug 7340 Opened 25 years ago Closed 25 years ago

General minor errors when Downloading Files

Categories

(Core Graveyard :: Tracking, defect, P2)

x86
Windows 95

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssym, Assigned: law)

Details

[Numerous minor things, I cannot be bothered to file new bug reports for each one because my connection is **SLOW**. SO I'm filing this ONE, and split it up if you want. I have not checked if dupes of all these bugs exist, mainly because the one query I ran (for "flicker") took approximately 5 mins to complete.] DESCRIPTION 1. The "Unknown File Type" box does not disappear at the right time. 2. The button on the "Save File" dialog should read "Save", not "Open"! 3. The "Saving File" dialog is never the right default size. 4. The horizontal bar in the "Saving File" dialog is klunky and inefficient. It flickers constantly. 5. It is possible to get a time-left reading of 60 minutes or 60 seconds. STEPS TO REPRODUCE 1. Start apprunner browser. 2. Go to a site you can download a file from, preferably a slow site so that the file will take some time to download. The site I used was ftp://ftp.mozilla.org/pub/mozilla/nightly/1999-05-28-08-M7/ from which I downloaded mozilla-win32.zip. Something that takes over an hour or two to download. 3. Click on the file you want. 4. A nice dialog box will appear, click on "Save File" 5. Another dialog box appears. Move this one around the screen to see Bug No. 1: the "Unknown File Type" box stays on the screen, being a huge eyesore, with the "Save File" button still depressed. 6. Bug No. 2: Look at the "Save File" dialog. The button on it says "Open". You're not opening a file, you're saving a file, so this is wrong. 7. Type in a filename and click on "Open". 8. Behold bugs 3 through 5. Firstly, the "Saving File" dialog opens, and needs to be resized so that the "Cancel" button can be seen. Secondly, look at the bar as it creeps across the box -- flickers nicely, no? Thirdly, look at the ETA of the file, and here you see why I suggested a SLOW site to download from. As the time reading creeps down, notice that it is possible to get readings containing "60 minutes" and/or "60 seconds". ACTUAL RESULTS -- look at RESULTS. EXPECTED RESULTS In the order of the bugs listed: 1. The "Unknown File Type" box should disappear immediately after you click on "Save File". 2. The button on the "Save File" dialog should read "Save" not "Open"!! 3. The "Saving File" dialog should be correctly sized by default. 4. The horizontal bar in the "Saving File" dialog should never flicker, it should move smoothly across the box. 5. The time-reading should *never* include "60 minutes" -- this should be carried over into the hours section of the time-reading. The same kind of argument applies to a "60 seconds" reading where one minute should be added to the minutes reading and "0 seconds" should be displayed instead. BUILD DATE & PLATFORM Build No. xxxxxxxxxxxxxxxxx using Win95 ver 4.00.1111 ADDITIONAL INFORMATION My screen display is set to 800x600 High color, refresh rate "Optimal" for a S3 Trio64V+. Using a Pentium 120-S w/48 Mb RAM.
Sorry, forgot to insert the Build No -- it's Build No. 1999052508.
QA Contact: leger → paulmac
Assignee: don → law
Priority: P3 → P2
Target Milestone: M9
Bill ...
Status: NEW → ASSIGNED
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
Target Milestone: M9 → M10
I think 1 and 3 are fixed. 2 requires enhancements to the file widget. 4 is a side effect of using Gecko to render the dialog (if I let it update more smoothly, it causes the time to be spent relaying out the dialog, rather than doing the download). But I might be able to tune it. 5 is trivial and will be fixed along with the rest (for M10, hopefully).
Severity: minor → major
I've bumped the Severity because this is a much harder problem to fix now. The Necko changes mean that the file download dialog code needs some major work. I'll be working on this and maybe get it into M11.
Target Milestone: M11 → M12
File downloading is still being worked on, see bug #10737.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I'm not sure I agree with item #1. If the user changes their mind about saving then it might make sense that they are returned from whence they came and given a chance to try something else. #2 is fixed (for the moment, we're replacing the underlying file-picker dialog code soon and if this breaks again, holler). #3 is fixed (although there are still some cosmetic issues for which bugs already exist). #4 is about as good as it gets, using xul <progressmeter> elements. The flickering should be gone (was due to painting problems in underlying code that have been resolved). #5 is still broken, I've opened a new bug (19019) to cover that. I'm marking this one resolved FIXED.
QA Contact: paulmac → sairuh
sairuh will be handling save as bugs, changing qa contact
Status: RESOLVED → VERIFIED
verified as fixed (ie, parts 1-4 of user's entry) with build 1999-12-02-11-m12 on NT. added myself to cc list of bug 19019.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.