Closed
Bug 734294
Opened 13 years ago
Closed 12 years ago
when installing an app the InstallTime is returning undefined
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: onecyrenus, Assigned: ianbicking)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
myk
:
checkin+
|
Details | Diff | Splinter Review |
navigator.mozApps.install in onSuccess
installTime = undefined
This is on mozilla-central.
|
||
Updated•13 years ago
|
|
Reporter | |
Comment 1•13 years ago
|
||
The difference I was seeing with the HTML / JS implementation here is that installTime in the onSuccess handler whereas in ff it is not.
It seems more natural for this to be returned later in getInstalled, which is the way ff does it .
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [mozApps API 1.0]
|
||
Updated•13 years ago
|
Component: DOM: Device Interfaces → DOM: Mozilla Extensions
QA Contact: device-interfaces → general
|
|
||
Updated•13 years ago
|
Whiteboard: [mozApps API 1.0]
|
Assignee | |
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
|
|
Assignee | |
Comment 2•12 years ago
|
||
One-line fix, plus MochiTest
Assignee: nobody → ianb
Attachment #632103 -
Flags: review?(fabrice)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 632103 [details] [diff] [review]
Fix for bug, plus test
Review of attachment 632103 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
::: dom/apps/src/Webapps.jsm
@@ +181,4 @@
> }
>
> let appObject = this._cloneAppObject(app);
> + appObject.installTime = app.installTime = (new Date()).getTime();
Nit: Date.now() is fine also
Attachment #632103 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #632103 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Comment on attachment 634085 [details] [diff] [review]
Fix with nit addressed
https://hg.mozilla.org/integration/mozilla-inbound/rev/92aa87e1e876
Attachment #634085 -
Flags: checkin+
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
||
Updated•12 years ago
|
Target Milestone: --- → mozilla16
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM: Apps
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•