Closed
Bug 734531
Opened 13 years ago
Closed 13 years ago
Get PersonaAuthor model or substitute
Categories
(addons.mozilla.org Graveyard :: Code Quality, defect)
addons.mozilla.org Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
6.4.8
People
(Reporter: andy+bugzilla, Assigned: andy+bugzilla)
References
Details
In bug 726186 I naively made the PersonAuthor a real Django model. This then uncovered the problems in bug 734256. Apparently we aren't ready for just flipping over PersonaAuthor to being a real user object.
Quite a lot of things have to be cleaned up, including but not limited to: the Addon transformer, the fact that persona tests assume and create a dummy user, the templates will just try and render all the stuff off the PersonaAuthor as if its just a user.
So I reverted 726186 apart from the migration.
What we've got to do is pull "make the PersonaAuthor a Django model" part out of that bug. Clean up. Write some tests, fix the above.
Then worry about linking up the migration.
Assignee | ||
Comment 1•13 years ago
|
||
Should be bug 734526.
Assignee | ||
Comment 2•13 years ago
|
||
I'm not sure what this model is for. Let's remove it and the references as noted above. Instead let's just use the standard AddonUser. Once that's working as expected, bug 726186 can land.
Assignee | ||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Assignee: nobody → amckay
Target Milestone: --- → 6.4.6
Comment 4•13 years ago
|
||
https://github.com/mozilla/zamboni/commit/d4caef5
Reverted per https://github.com/mozilla/zamboni/commit/fd3ad4#commitcomment-1090991 to fix bug 736150.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•13 years ago
|
Target Milestone: 6.4.6 → 6.4.8
Assignee | ||
Comment 5•13 years ago
|
||
https://github.com/mozilla/zamboni/commit/efc0e8
If this is still a problem got lots of time to fix and avoid reverting :)
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•