Closed
Bug 734685
Opened 13 years ago
Closed 13 years ago
Support IPC Thread::SetName on Mac
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
Screenshot (IPC thread 5+21 fixed by this patch)
Useful for gdb, this code is an adaption from chromium/src/base/threading/platform_thread_posix.cc.
Attachment #604687 -
Flags: review?(jones.chris.g)
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•13 years ago
|
Component: Graphics → IPC
QA Contact: thebes → ipc
|
||
Comment 2•13 years ago
|
||
Is this related to bug 720778 at all?
Comment on attachment 604687 [details] [diff] [review]
patch
Did you check if this was fixed in upstream chromium? I'd be happy to pull a change from there, too.
>+ std::string shortened_name = std::string(name).substr(0, kMaxNameLength);
>+ // pthread_setname() fails (harmlessly) in the sandbox, ignore when it does.
>+ // See http://crbug.com/47058
>+ dynamic_pthread_setname_np(shortened_name.c_str());
What's the ownership model for the pointer here? Please doc.
r=me with ownership clarified (/ proven correct ;) ).
Attachment #604687 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
I got the code from 'chromium/src/base/threading/platform_thread_posix.cc', wouldn't that be upstream? The change doesn't apply cleanly so I had to make a patch manually.
|
|
Assignee | |
Comment 5•13 years ago
|
||
I looked in bionic and it's implemented by copying name:
bionic/libc/bionic/pthread.c
So it must certainly be the same elsewhere. I'll add a comment when checking in.
|
|
Assignee | |
Comment 6•13 years ago
|
||
Pulling from upstream is good. Would prefer you check the darwin docs, but r+ from upstream (hopefully) means someone else already checked docs.
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla14
|
|
||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•