Closed Bug 734924 Opened 13 years ago Closed 10 years ago

add unittests to balrog's javascript code

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P2)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (frontend)
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Unassigned)

References

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2351] [balrog])

bug 672918 is going to add a lot of client side javascript that's crucial to the admin interface functioning. Currently, there's no tests for it because I haven't figured out how to effectively test javascript. #webdev mentioned qunit + monkey patching of jQuery's ajax() method to simulate results, which sounds worth a try. bug 672918 needs to land soon to unblock over things, so we'll have to add the tests after the fact.
I've got a working framework for testing JS on this branch: https://github.com/bhearsum/balrog/compare/master...qunit It imports qunit into Balrog, and requires phantomjs to actually run the tests as part of 'make test'.
Blocks: balrog-frontend
No longer blocks: balrog
Whiteboard: [balrog]
Not a big priority right now. More of a nice to have, really.
Assignee: bhearsum → nobody
Priority: -- → P2
Product: mozilla.org → Release Engineering
Component: General Automation → Balrog: Frontend
QA Contact: catlee → bhearsum
Whiteboard: [balrog] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2336] [balrog]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2336] [balrog] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2351] [balrog]
The new ui has tests.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.