Kan-Ru Chen [:kanru] (UTC+9) Reporter
	Description • 13 years ago

CALL_STATE_RINGING is confusing. It looks like the caller side is ringing but actually it is notifying the carrier (the callee side) a new call. Changing it to CALL_STATE_ALERTING not only matches it with rild state but also provides consistence with RIL terminology.

	Philipp von Weitershausen [:philikon]
	Comment 1 • 13 years ago

Good point, make it so!

	Hsin-Yi Tsai (she/her) [:hsinyi] Assignee
	Comment 2 • 13 years ago

I have changed CALL_STATE_RINGING to CALL_STATE_ALERTING and related terms.

	Philipp von Weitershausen [:philikon]
	Comment 3 • 13 years ago

Comment on attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Please request review when you upload a patch. Thanks!

	Philipp von Weitershausen [:philikon]
	Comment 4 • 13 years ago

Comment on attachment 605665 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Wait, I thought this was only about nsIRadioInterfaceLayer. Now you're also changing the WebTelephony API. We should discuss the latter change on dev-webapi first since it has implications for the users of the API (Gaia being just one of them). Please start a thread there. Thanks!

Apart from that, you need to update an interface's UUID each time you change it, so r- for that.

	Hsin-Yi Tsai (she/her) [:hsinyi] Assignee
	Comment 5 • 13 years ago

Thanks for the comment.
In this patch, I only made changes about nsIRadioInterfaceLayer, instead of WebTelephony API. Also updated the UUID of the modified interface.

I started a new thread about changing WebTelephony API on dev-webapi. Let's wait for other's comments there.

	Philipp von Weitershausen [:philikon]
	Comment 6 • 13 years ago

Comment on attachment 605715 [details] [diff] [review]
change nsIRadioInterfaceLayer::CALL_STATE_RINGING to CALL_STATE_ALERTING

Looks good! r=me

	Philipp von Weitershausen [:philikon]
	Comment 7 • 13 years ago

Due to the very likely merge conflict from bug 735017, I'm going to handle the check in for this patch, so I'm removing the checkin-needed flag.

	Philipp von Weitershausen [:philikon]
	Comment 8 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/f378bd681310