Closed Bug 735196 Opened 13 years ago Closed 12 years ago

Support "bugs.php.net" URLs in "See also" field

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Version:
3.4.4
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: thomas8, Assigned: selsky)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

Add support for bugs.php.net, v4
(deleted), patch
gerv
: review+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #543667 +++ From bug 577847, comment 12, there's a patch from Marcin CIESLAK to support "bugs.php.net" URLs in "See also" field. I've moved that patch here so that it can be reviewed in its own bug.
Comment on attachment 605346 [details] [diff] [review] Patch by Marcin CIESLAK to support "bugs.php.net" URLs in "See also" field This is old code. The See Also code has been moved into BugUrl/*. Also, I don't think we need to support php.net in our core code. It should go into the MoreBugUrl extension.
Attachment #605346 - Flags: review-
Frédéric, could you provide an mxr link to the MoreBugURL extension, so that Marcin might provide a new patch?
it's an extension which is bundled with bugzilla: http://bzr.mozilla.org/bugzilla/trunk/files/head:/extensions/MoreBugUrl/
Attachment #605346 - Attachment is patch: true
Attachment #605346 - Attachment is obsolete: true
Comment on attachment 605381 [details] [diff] [review] Patch for trunk This is a good candidate for the MoreBugUrl extension, see comment 1. Also next time, do not forget to request review from timello, to put your patch in his radar.
Attachment #605381 - Flags: review-
Attached patch Add support for bugs.php.net, v2 (obsolete) (deleted) — — Splinter Review
Assignee: create-and-change → selsky
Attachment #605381 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #616137 - Flags: review?(timello)
Comment on attachment 616137 [details] [diff] [review] Add support for bugs.php.net, v2 r=gerv. Gerv
Attachment #616137 - Flags: review?(timello) → review+
Flags: approval?
Comment on attachment 616137 [details] [diff] [review] Add support for bugs.php.net, v2 >=== modified file 'extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl' >+<li>A bug on bugs.php.net.</li> Doesn't pass tests. Bareword "A bug" should either be "[% terms.Abug %] or renamed to something else. Please update your patch.
Flags: approval?
Keywords: relnote
Target Milestone: --- → Bugzilla 4.4
Attached patch Add support for bugs.php.net, v3 (obsolete) (deleted) — — Splinter Review
Renamed "A bug" as requested.
Attachment #616137 - Attachment is obsolete: true
Attachment #621490 - Flags: review?(gerv)
Comment on attachment 621490 [details] [diff] [review] Add support for bugs.php.net, v3 r=gerv. Gerv
Attachment #621490 - Flags: review?(gerv) → review+
Flags: approval?
Comment on attachment 621490 [details] [diff] [review] Add support for bugs.php.net, v3 >=== modified file 'extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl' >+<li>A b[% %]ug on bugs.php.net.</li> bugs.php.net must also be written as b[% %]ugs.php.net, else t/009bugwords.t will catch it.
Flags: approval? → approval+
Update for bitrot from bug 571740. Also fixes test breakage from the php website url.
Attachment #626558 - Flags: review?(gerv)
Attachment #621490 - Attachment is obsolete: true
Comment on attachment 626558 [details] [diff] [review] Add support for bugs.php.net, v4 r=gerv. Gerv
Attachment #626558 - Flags: review?(gerv) → review+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified extensions/MoreBugUrl/Extension.pm added extensions/MoreBugUrl/lib/PHP.pm modified extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl Committed revision 8241.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Added to relnotes for 4.4.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: